Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755213Ab0HIGoo (ORCPT ); Mon, 9 Aug 2010 02:44:44 -0400 Received: from one.firstfloor.org ([213.235.205.2]:60342 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989Ab0HIGon (ORCPT ); Mon, 9 Aug 2010 02:44:43 -0400 Date: Mon, 9 Aug 2010 08:44:41 +0200 From: Andi Kleen To: Namhyung Kim Cc: Andi Kleen , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: remove __phys_reloc_hide Message-ID: <20100809064441.GC29524@basil.fritz.box> References: <1281303490-390-1-git-send-email-namhyung@gmail.com> <87k4o08fv9.fsf@basil.nowhere.org> <1281336031.976.11.camel@leonhard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1281336031.976.11.camel@leonhard> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 636 Lines: 16 > I'm not talking about the RELOC_HIDE itself. I do know we need it for > some specific case, ie. percpu. But in this case __pa_symbol(x) is > expanded to RELOC_HIDE((unsigned long)(x), 0) which does nothing > meaningful. I believe the overflow is not a concern here. It hides the value conversion from the compiler through asm() -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/