Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755727Ab0HIIgK (ORCPT ); Mon, 9 Aug 2010 04:36:10 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:58701 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755258Ab0HIIgI (ORCPT ); Mon, 9 Aug 2010 04:36:08 -0400 Subject: Re: [PATCH] regulator: max8660 - fix a memory leak in max8660_remove() From: Liam Girdwood To: Axel Lin Cc: linux-kernel , Mark Brown , Wolfram Sang In-Reply-To: <1281072927.24426.5.camel@mola> References: <1281072927.24426.5.camel@mola> Content-Type: text/plain; charset="UTF-8" Date: Mon, 09 Aug 2010 09:36:00 +0100 Message-ID: <1281342960.3035.4.camel@odin> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 30 On Fri, 2010-08-06 at 13:35 +0800, Axel Lin wrote: > In max8660_probe(), we allocate memory for max660. > In max8660_remove(), current implementation only free rdev > which is a member of struct max8660. > Thus, there is a small memory leak when we unload the module. > > This patch fixes the memory leak by passing max660 to i2c clientdata, > and properly kfree(max8660) in max8660_remove(). > > Signed-off-by: Axel Lin > --- > drivers/regulator/max8660.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > Applied. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/