Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756055Ab0HIJ7l (ORCPT ); Mon, 9 Aug 2010 05:59:41 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:36133 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755835Ab0HIJ7k (ORCPT ); Mon, 9 Aug 2010 05:59:40 -0400 Subject: Re: [PATCH RESEND again] regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write() From: Liam Girdwood To: Axel Lin Cc: linux-kernel , Mark Brown , Marek Szyprowski , Kyungmin Park In-Reply-To: <1281344481.22819.3.camel@mola> References: <1281344481.22819.3.camel@mola> Content-Type: text/plain; charset="UTF-8" Date: Mon, 09 Aug 2010 10:59:25 +0100 Message-ID: <1281347965.3035.21.camel@odin> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 26 On Mon, 2010-08-09 at 17:01 +0800, Axel Lin wrote: > i2c_smbus_write_byte_data() returns zero or negative value, > therefore no need to check if ret is greater than zero or not. > > Signed-off-by: Axel Lin > Acked-by: Mark Brown > --- > drivers/regulator/lp3971.c | 8 +------- > 1 files changed, 1 insertions(+), 7 deletions(-) > Applied. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/