Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757497Ab0HJFPy (ORCPT ); Tue, 10 Aug 2010 01:15:54 -0400 Received: from li190-28.members.linode.com ([178.79.134.28]:53941 "EHLO freeflow.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624Ab0HJFPu (ORCPT ); Tue, 10 Aug 2010 01:15:50 -0400 X-Greylist: delayed 616 seconds by postgrey-1.27 at vger.kernel.org; Tue, 10 Aug 2010 01:15:50 EDT Message-ID: <4C60DE0E.2000707@kernel.org> Date: Tue, 10 Aug 2010 08:05:18 +0300 From: Pekka Enberg User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 MIME-Version: 1.0 To: ngupta@vflare.org CC: Pekka Enberg , Minchan Kim , Andrew Morton , Greg KH , Linux Driver Project , linux-mm , linux-kernel Subject: Re: [PATCH 04/10] Use percpu buffers References: <1281374816-904-1-git-send-email-ngupta@vflare.org> <1281374816-904-5-git-send-email-ngupta@vflare.org> <4C60D9E6.3050700@vflare.org> In-Reply-To: <4C60D9E6.3050700@vflare.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1775 Lines: 36 Hi Nitin, On 10.8.2010 7.47, Nitin Gupta wrote: > On 08/10/2010 12:27 AM, Pekka Enberg wrote: >> On Mon, Aug 9, 2010 at 8:26 PM, Nitin Gupta wrote: >>> @@ -303,38 +307,41 @@ static int zram_write(struct zram *zram, struct bio *bio) >>> zram_test_flag(zram, index, ZRAM_ZERO)) >>> zram_free_page(zram, index); >>> >>> - mutex_lock(&zram->lock); >>> + preempt_disable(); >>> + zbuffer = __get_cpu_var(compress_buffer); >>> + zworkmem = __get_cpu_var(compress_workmem); >>> + if (unlikely(!zbuffer || !zworkmem)) { >>> + preempt_enable(); >>> + goto out; >>> + } >> The per-CPU buffer thing with this preempt_disable() trickery looks >> overkill to me. Most block device drivers seem to use mempool_alloc() >> for this sort of thing. Is there some reason you can't use that here? >> > Other block drivers are allocating relatively small structs using > mempool_alloc(). However, in case of zram, these buffers are quite > large (compress_workmem is 64K!). So, allocating them on every write > would probably be much slower than using a pre-allocated per-cpu buffer. The mempool API is precisely for that - using pre-allocated buffers instead of allocating every time. The preempt_disable() games make the code complex and have the downside of higher scheduling latencies so why not give mempools a try? Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/