Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756466Ab0HJJjr (ORCPT ); Tue, 10 Aug 2010 05:39:47 -0400 Received: from mgw-sa02.nokia.com ([147.243.1.48]:19567 "EHLO mgw-sa02.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219Ab0HJJjo (ORCPT ); Tue, 10 Aug 2010 05:39:44 -0400 Date: Tue, 10 Aug 2010 12:37:17 +0300 From: Felipe Balbi To: ext Christian Dietrich Cc: David Howells , Tejun Heo , "linux-kernel@vger.kernel.org" , "vamos-dev@i4.informatik.uni-erlangen.de" Subject: Re: [PATCH 1/4] arch/frv: Removing dead RAMKERNEL config option Message-ID: <20100810093717.GD22436@nokia.com> Reply-To: felipe.balbi@nokia.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1338 Lines: 42 Hi, On Tue, Aug 10, 2010 at 11:11:08AM +0200, ext Christian Dietrich wrote: >diff --git a/arch/frv/mm/init.c b/arch/frv/mm/init.c >index ed64588..73586ad 100644 >--- a/arch/frv/mm/init.c >+++ b/arch/frv/mm/init.c >@@ -170,23 +170,6 @@ void __init mem_init(void) > */ > void free_initmem(void) > { >-#if defined(CONFIG_RAMKERNEL) && !defined(CONFIG_PROTECT_KERNEL) >- unsigned long start, end, addr; >- >- start = PAGE_ALIGN((unsigned long) &__init_begin); /* round up */ >- end = ((unsigned long) &__init_end) & PAGE_MASK; /* round down */ >- >- /* next to check that the page we free is not a partial page */ >- for (addr = start; addr < end; addr += PAGE_SIZE) { >- ClearPageReserved(virt_to_page(addr)); >- init_page_count(virt_to_page(addr)); >- free_page(addr); >- totalram_pages++; >- } >- >- printk("Freeing unused kernel memory: %ldKiB freed (0x%lx - 0x%lx)\n", >- (end - start) >> 10, start, end); >-#endif > } /* end free_initmem() */ and now you have an empty function... how about removing the function completely and it's uses ? -- balbi DefectiveByDesign.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/