Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932350Ab0HJQK1 (ORCPT ); Tue, 10 Aug 2010 12:10:27 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:45582 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932130Ab0HJQKV convert rfc822-to-8bit (ORCPT ); Tue, 10 Aug 2010 12:10:21 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=IqXQJuP+481wJxQU9LyoDVQzmC7SqyRD1uo3iQXXDh0ZEAnzehrS/LBUnEpERfxk8A exAVTTAYnMOMIlc0wxCRta00DAsMeENSM9SRLX6oV5rtnjV1xYJjZod0n8jLs4osPq1o tJBDSTFl5hp3be1vGls4t1e5Uhd3f1QZ7WaNE= MIME-Version: 1.0 In-Reply-To: References: <6f90103dea29739de0f4f0ede3f3da68afe84343.1281295424.git.mina86@mina86.com> <419733287a42072a658f0f74d0b1901132178b75.1281295424.git.mina86@mina86.com> <201008100615.52510.vda.linux@googlemail.com> Date: Tue, 10 Aug 2010 18:10:19 +0200 Message-ID: Subject: Re: [PATCHv2 2/3] lib: vsprintf: optimised put_dec() for 32-bit machines From: Denys Vlasenko To: =?ISO-8859-2?Q?Micha=B3_Nazarewicz?= Cc: Michal Nazarewicz , linux-kernel@vger.kernel.org, "Douglas W. Jones" , Andrew Morton Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 558 Lines: 16 2010/8/10 Michał Nazarewicz : >>> +#if BITS_PER_LONG != 32 || defined CONFIG_CC_OPTIMIZE_FOR_SIZE || \ >>> +       ULLONG_MAX != 18446744073709551615ULL >> >> I think it's better to say "if BITS_PER_LONG > 32 and ULLONG_MAX > >> 2^64-1", Thinko. I meant "or", not "and"... -- vda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/