Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932405Ab0HJQlk (ORCPT ); Tue, 10 Aug 2010 12:41:40 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:56864 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932370Ab0HJQlh (ORCPT ); Tue, 10 Aug 2010 12:41:37 -0400 Date: Tue, 10 Aug 2010 09:40:59 -0700 From: Randy Dunlap To: Stephen Rothwell , Samuel Ortiz Cc: linux-next@vger.kernel.org, LKML Subject: [PATCH -next] mfd: tps6586x depends on GPIOLIB Message-Id: <20100810094059.c320b916.randy.dunlap@oracle.com> In-Reply-To: <20100810135601.4777e310.sfr@canb.auug.org.au> References: <20100810135601.4777e310.sfr@canb.auug.org.au> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1561 Lines: 37 From: Randy Dunlap tps6586x uses gpio interfaces, so it should depend on GPIOLIB. Fixes these build errors: drivers/mfd/tps6586x.c:41: error: field 'gpio' has incomplete type drivers/mfd/tps6586x.c:195: warning: type defaults to 'int' in declaration of '__mptr' drivers/mfd/tps6586x.c:195: warning: initialization from incompatible pointer type drivers/mfd/tps6586x.c:210: warning: type defaults to 'int' in declaration of '__mptr' drivers/mfd/tps6586x.c:210: warning: initialization from incompatible pointer type drivers/mfd/tps6586x.c:219: warning: type defaults to 'int' in declaration of '__mptr' drivers/mfd/tps6586x.c:219: warning: initialization from incompatible pointer type drivers/mfd/tps6586x.c:249: error: implicit declaration of function 'gpiochip_add' Signed-off-by: Randy Dunlap Cc: Samuel Ortiz --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20100810.orig/drivers/mfd/Kconfig +++ linux-next-20100810/drivers/mfd/Kconfig @@ -543,7 +543,7 @@ config MFD_JZ4740_ADC config MFD_TPS6586X tristate "TPS6586x Power Management chips" - depends on I2C + depends on I2C && GPIOLIB select MFD_CORE help If you say yes here you get support for the TPS6586X series of -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/