Message-ID: <000601cb391e$afec6b60$66f8800a@maildom.okisemi.com>
From: "Masayuki Ohtake" <masa-korg@dsn.okisemi.com>
To: "Greg KH" <gregkh@suse.de>
Cc: "Wang, Qi" <qi.wang@intel.com>, <meego-dev@meego.com>,
        "LKML" <linux-kernel@vger.kernel.org>,
        "Wang, Yong Y" <yong.y.wang@intel.com>,
        "Khor, Andrew Chih Howe" <andrew.chih.howe.khor@intel.com>,
        <arjan@linux.intel.com>
References: <002c01cb390e$80a58e50$66f8800a@maildom.okisemi.com> <20100811043952.GA4669@suse.de>
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35
Date: Wed, 11 Aug 2010 15:30:20 +0900
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1220
Lines: 38

Hi Greg,

> Use the 'bool' type, and 'true' and/or 'false' keywords instead.  That
> is the proper C idiom.
I can do well.

Thanks, Ohtake.

----- Original Message ----- 
From: "Greg KH" <gregkh@suse.de>
To: "Masayuki Ohtake" <masa-korg@dsn.okisemi.com>
Cc: "Wang, Qi" <qi.wang@intel.com>; <meego-dev@meego.com>; "LKML" <linux-kernel@vger.kernel.org>; "Wang, Yong Y"
<yong.y.wang@intel.com>; "Khor, Andrew Chih Howe" <andrew.chih.howe.khor@intel.com>; <arjan@linux.intel.com>
Sent: Wednesday, August 11, 2010 1:39 PM
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35


> On Wed, Aug 11, 2010 at 01:34:33PM +0900, Masayuki Ohtake wrote:
> > Hi Qi-san
> >
> > I have found Macro 'TRUE' and 'FALSE' are used as setting value in the driver; still,
> > can't I use TRUE/FALSE macro ?
> > If not, How should we implement ?
>
> Use the 'bool' type, and 'true' and/or 'false' keywords instead.  That
> is the proper C idiom.
>
> thanks,
>
> greg k-h
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/