Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750828Ab0HKKWQ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Aug 2010 06:22:16 -0400
Received: from na3sys009aog102.obsmtp.com ([74.125.149.69]:54440 "EHLO
	na3sys009aog102.obsmtp.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750727Ab0HKKWP convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Aug 2010 06:22:15 -0400
From: "Desai, Kashyap" <Kashyap.Desai@lsi.com>
To: Julia Lawall <julia@diku.dk>, "Moore, Eric" <Eric.Moore@lsi.com>,
        "Support, Software" <support@lsi.com>,
        DL-MPT Fusion Linux <DL-MPTFusionLinux@lsi.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Date: Wed, 11 Aug 2010 15:49:45 +0530
Subject: RE: [PATCH 3/5] drivers/message/fusion: Return -ENOMEM on memory
 allocation failure
Thread-Topic: [PATCH 3/5] drivers/message/fusion: Return -ENOMEM on memory
 allocation failure
Thread-Index: Acs5PZYsbom20wB8TnaVlus/JuM5tQAAMCXQ
Message-ID: <1C9608B8A4CD534FB19C7C7543CBB249029923A0BD@inbmail02.lsi.com>
References: <Pine.LNX.4.64.1008111211080.8669@ask.diku.dk>
In-Reply-To: <Pine.LNX.4.64.1008111211080.8669@ask.diku.dk>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1817
Lines: 69



> -----Original Message-----
> From: Julia Lawall [mailto:julia@diku.dk]
> Sent: Wednesday, August 11, 2010 3:41 PM
> To: Moore, Eric; Support, Software; DL-MPT Fusion Linux; linux-
> scsi@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: [PATCH 3/5] drivers/message/fusion: Return -ENOMEM on memory
> allocation failure
> 
> From: Julia Lawall <julia@diku.dk>
> 
> In this code, 0 is returned on memory allocation failure, even though
> other
> failures return -ENOMEM or other similar values.
> 
> A simplified version of the semantic match that finds this problem is
> as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression ret;
> expression x,e1,e2,e3;
> @@
> 
> ret = 0
> ... when != ret = e1
> *x = \(kmalloc\|kcalloc\|kzalloc\)(...)
> ... when != ret = e2
> if (x == NULL) { ... when != ret = e3
>   return ret;
> }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@diku.dk>
> 
> ---
>  drivers/message/fusion/mptbase.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/message/fusion/mptbase.c
> b/drivers/message/fusion/mptbase.c
> index d8c668d..49f8ec1 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -5954,8 +5954,10 @@ mpt_findImVolumes(MPT_ADAPTER *ioc)
>  		goto out;
> 
>  	mem = kmalloc(iocpage2sz, GFP_KERNEL);
> -	if (!mem)
> +	if (!mem) {
> +		rc = -ENOMEM;
>  		goto out;
> +	}

ACKed.

Thanks, Kashyap

> 
>  	memcpy(mem, (u8 *)pIoc2, iocpage2sz);
>  	ioc->raid_data.pIocPg2 = (IOCPage2_t *) mem;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/