Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758258Ab0HKRZV (ORCPT ); Wed, 11 Aug 2010 13:25:21 -0400 Received: from mgw-sa02.nokia.com ([147.243.1.48]:58827 "EHLO mgw-sa02.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537Ab0HKRZU (ORCPT ); Wed, 11 Aug 2010 13:25:20 -0400 Date: Wed, 11 Aug 2010 20:25:32 +0300 From: Felipe Balbi To: ext Jacob Tanenbaum Cc: "linux@arm.linux.org.uk" , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "rmk@arm.linux.org.uk" , "tony@atomide.com" Subject: Re: [PATCH 2/4] Low-level initialization for hsmmc controller on LogicPD's OMAP3 SOM and TORPEDO dev kits Message-ID: <20100811172532.GB21391@nokia.com> Reply-To: felipe.balbi@nokia.com References: <1281544297-18015-1-git-send-email-Jacob.Tanenbaum@logicpd.com> <1281544297-18015-2-git-send-email-Jacob.Tanenbaum@logicpd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1281544297-18015-2-git-send-email-Jacob.Tanenbaum@logicpd.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1454 Lines: 60 Hi, On Wed, Aug 11, 2010 at 06:31:35PM +0200, ext Jacob Tanenbaum wrote: >+#define OMAP3_TORPEDO_MMC_GPIO_WP (-EINVAL) this one isn't used anywhere, why adding it ? >+static struct regulator_init_data omap3logic_vmmc1 = { >+ .constraints = { >+ .name = "VMMC1", >+ .min_uV = 1850000, >+ .max_uV = 3150000, >+ .valid_modes_mask = REGULATOR_MODE_NORMAL >+ | REGULATOR_MODE_STANDBY, >+ .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE >+ | REGULATOR_CHANGE_MODE >+ | REGULATOR_CHANGE_STATUS, >+ }, >+ .num_consumer_supplies = 1, >+ .consumer_supplies = &omap3logic_vmmc1_supply, >+}; >+ >+ >+ one blank line only. >+ } else { >+ printk(KERN_ERR "%s(): unknown machine type\n", __func__); >+ return; indentation is wrong. >+ omap2_hsmmc_init(board_mmc_info); >+ /* link regulators to MMC adapters */ >+ omap3logic_vmmc1_supply.dev = board_mmc_info[0].dev; >+} >+ >+ >+ one blank line only. > /* Ensure SDRC pins are mux'd for self-refresh */ >-/* omap_cfg_reg(H16_34XX_SDRC_CKE0); >- omap_cfg_reg(H17_34XX_SDRC_CKE1); >- omap_cfg_reg(SDRC_CKE0); >- omap_cfg_reg(SDRC_CKE1); */ this shouldn't even be here in the first place. :-) -- balbi DefectiveByDesign.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/