Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758248Ab0HKRos (ORCPT ); Wed, 11 Aug 2010 13:44:48 -0400 Received: from imr4.ericy.com ([198.24.6.8]:43800 "EHLO imr4.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753424Ab0HKRor (ORCPT ); Wed, 11 Aug 2010 13:44:47 -0400 Subject: Re: [PATCH -next] hwmon: jc42 depends on I2C From: Guenter Roeck Reply-To: guenter.roeck@ericsson.com To: Randy Dunlap CC: Stephen Rothwell , "lm-sensors@lm-sensors.org" , "linux-next@vger.kernel.org" , LKML , akpm In-Reply-To: <20100811103511.41428e62.randy.dunlap@oracle.com> References: <20100811140009.6ff33109.sfr@canb.auug.org.au> <20100811103511.41428e62.randy.dunlap@oracle.com> Content-Type: text/plain; charset="UTF-8" Organization: Ericsson Date: Wed, 11 Aug 2010 10:43:31 -0700 Message-ID: <1281548611.5745.287.camel@groeck-laptop> MIME-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1487 Lines: 36 On Wed, 2010-08-11 at 13:35 -0400, Randy Dunlap wrote: > From: Randy Dunlap > > jc42 uses i2c interfaces, so it should depend on I2C. > > drivers/hwmon/jc42.c:426: error: implicit declaration of function 'i2c_check_functionality' > drivers/hwmon/jc42.c:521: error: implicit declaration of function 'i2c_smbus_read_word_data' > drivers/hwmon/jc42.c:529: error: implicit declaration of function 'i2c_smbus_write_word_data' > drivers/hwmon/jc42.c:580: error: implicit declaration of function 'i2c_add_driver' > drivers/hwmon/jc42.c:585: error: implicit declaration of function 'i2c_del_driver' > > Signed-off-by: Randy Dunlap > Cc: lm-sensors@lm-sensors.org Acked-by: Guenter Roeck > --- > drivers/hwmon/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20100811.orig/drivers/hwmon/Kconfig > +++ linux-next-20100811/drivers/hwmon/Kconfig > @@ -465,6 +465,7 @@ config SENSORS_JZ4740 > > config SENSORS_JC42 > tristate "JEDEC JC42.4 compliant temperature sensors" > + depends on I2C > help > If you say yes here you get support for Jedec JC42.4 compliant > temperature sensors. Support will include, but not be limited to, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/