Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758413Ab0HKRyz (ORCPT ); Wed, 11 Aug 2010 13:54:55 -0400 Received: from pfepa.post.tele.dk ([195.41.46.235]:39168 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758394Ab0HKRyx (ORCPT ); Wed, 11 Aug 2010 13:54:53 -0400 Date: Wed, 11 Aug 2010 19:54:50 +0200 From: Sam Ravnborg To: Jacob Tanenbaum Cc: linux@arm.linux.org.uk, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, rmk@arm.linux.org.uk, tony@atomide.com Subject: Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits Message-ID: <20100811175450.GA17425@merkur.ravnborg.org> References: <1281544297-18015-1-git-send-email-Jacob.Tanenbaum@logicpd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1281544297-18015-1-git-send-email-Jacob.Tanenbaum@logicpd.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2193 Lines: 72 Hi Jacob. Some quick comments. Sam > diff --git a/arch/arm/configs/omap3_defconfig b/arch/arm/configs/omap3_defconfig > index 5db9a6b..f510dfd 100644 > --- a/arch/arm/configs/omap3_defconfig > +++ b/arch/arm/configs/omap3_defconfig > @@ -37,6 +37,8 @@ CONFIG_MACH_OMAP_2430SDP=y > CONFIG_MACH_OMAP3_BEAGLE=y > CONFIG_MACH_DEVKIT8000=y > CONFIG_MACH_OMAP_LDP=y > +CONFIG_MACH_OMAP3530_LV_SOM=y > +CONFIG_MACH_OMAP3_TORPEDO=y > CONFIG_MACH_OVERO=y > CONFIG_MACH_OMAP3EVM=y > CONFIG_MACH_OMAP3517EVM=y Are the omap3_defconfig supposed to enable all omap board variants? Otherwise leave this change out. > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index b48bacf..42e7d4a 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -135,6 +135,14 @@ config MACH_OMAP_LDP > default y > select OMAP_PACKAGE_CBB > > +config MACH_OMAP3530_LV_SOM > + bool "OMAP3 Logic 3530 LV SOM board" > + depends on ARCH_OMAP3 > + > +config MACH_OMAP3_TORPEDO > + bool "OMAP3 Logic 35x Torpedo board" > + depends on ARCH_OMAP3 > + Some help would be beneficial. URL's to product descriptions etc could be included there. You may alos consider telling people this is a TI deriviate etc. > +static void __init omap3logic_init_irq(void) > +{ > + omap_board_config = omap3logic_config; > + omap_board_config_size = ARRAY_SIZE(omap3logic_config); > + omap2_init_common_hw(mt46h32m32lf6_sdrc_params, > + mt46h32m32lf6_sdrc_params); > + omap_init_irq(); > +#ifdef CONFIG_OMAP_32K_TIMER > + omap2_gp_clockevent_set_gptimer(12); > +#endif Fix this on the called site. There is zero reason to sprinkle all user of omap2_gp_clockevent_set_gptimer() with ifdef/endif. > + /* Ensure SDRC pins are mux'd for self-refresh */ > +/* omap_cfg_reg(H16_34XX_SDRC_CKE0); > + omap_cfg_reg(H17_34XX_SDRC_CKE1); > + omap_cfg_reg(SDRC_CKE0); > + omap_cfg_reg(SDRC_CKE1); */ Why do we have code that is not in use? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/