Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755586Ab0HKSr1 (ORCPT ); Wed, 11 Aug 2010 14:47:27 -0400 Received: from mail.logicpd.com ([66.162.60.3]:1623 "EHLO smtp.logicpd.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754982Ab0HKSr0 convert rfc822-to-8bit (ORCPT ); Wed, 11 Aug 2010 14:47:26 -0400 Content-class: urn:content-classes:message Subject: RE: [PATCH 2/4] Low-level initialization for hsmmc controller on LogicPD's OMAP3 SOM and TORPEDO dev kits MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Date: Wed, 11 Aug 2010 13:47:24 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <77A0A4DB5BF2A44283E5522C27234AC6021C82BC@EDPRSRV011.logicpd.com> In-Reply-To: <20100811172532.GB21391@nokia.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 2/4] Low-level initialization for hsmmc controller on LogicPD's OMAP3 SOM and TORPEDO dev kits Thread-Index: Acs5eiw/NZm9iGEyTTGsnWnTzDclAgACzD7g From: "Jacob Tanenbaum" To: Cc: , , , , X-OriginalArrivalTime: 11 Aug 2010 18:47:25.0408 (UTC) FILETIME=[A3F09E00:01CB3985] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1967 Lines: 83 -----Original Message----- From: Felipe Balbi [mailto:felipe.balbi@nokia.com] Sent: Wednesday, August 11, 2010 1:26 PM To: Jacob Tanenbaum Cc: linux@arm.linux.org.uk; linux-omap@vger.kernel.org; linux-kernel@vger.kernel.org; rmk@arm.linux.org.uk; tony@atomide.com Subject: Re: [PATCH 2/4] Low-level initialization for hsmmc controller on LogicPD's OMAP3 SOM and TORPEDO dev kits Hi, On Wed, Aug 11, 2010 at 06:31:35PM +0200, ext Jacob Tanenbaum wrote: >+#define OMAP3_TORPEDO_MMC_GPIO_WP (-EINVAL) this one isn't used anywhere, why adding it ? will fix >+static struct regulator_init_data omap3logic_vmmc1 = { >+ .constraints = { >+ .name = "VMMC1", >+ .min_uV = 1850000, >+ .max_uV = 3150000, >+ .valid_modes_mask = REGULATOR_MODE_NORMAL >+ | REGULATOR_MODE_STANDBY, >+ .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE >+ | REGULATOR_CHANGE_MODE >+ | REGULATOR_CHANGE_STATUS, >+ }, >+ .num_consumer_supplies = 1, >+ .consumer_supplies = &omap3logic_vmmc1_supply, >+}; >+ >+ >+ one blank line only. Will fix >+ } else { >+ printk(KERN_ERR "%s(): unknown machine type\n", __func__); >+ return; indentation is wrong. Will fix >+ omap2_hsmmc_init(board_mmc_info); >+ /* link regulators to MMC adapters */ >+ omap3logic_vmmc1_supply.dev = board_mmc_info[0].dev; >+} >+ >+ >+ one blank line only. Will fix > /* Ensure SDRC pins are mux'd for self-refresh */ >-/* omap_cfg_reg(H16_34XX_SDRC_CKE0); >- omap_cfg_reg(H17_34XX_SDRC_CKE1); >- omap_cfg_reg(SDRC_CKE0); >- omap_cfg_reg(SDRC_CKE1); */ this shouldn't even be here in the first place. :-) I removed this code and made a mistake in the rebase, it is removed in patch 4 will fix -- balbi DefectiveByDesign.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/