From: "Wang, Qi" <qi.wang@intel.com>
To: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
CC: "meego-dev@meego.com" <meego-dev@meego.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Wang, Yong Y" <yong.y.wang@intel.com>,
        "Khor, Andrew Chih Howe" <andrew.chih.howe.khor@intel.com>,
        "arjan@linux.intel.com" <arjan@linux.intel.com>,
        Greg KH <gregkh@suse.de>
Date: Thu, 12 Aug 2010 10:15:37 +0800
Subject: RE: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to
 2.6.35
Thread-Topic: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to
 2.6.35
Thread-Index: Acs5wxjCh2I8+USFT6CdA1qjW+z7rQAAPPWw
Message-ID: <D5AB6E638E5A3E4B8F4406B113A5A19A28EA272F@shsmsx501.ccr.corp.intel.com>
References: <4C612AA4.5040100@dsn.okisemi.com>
 <20100810171343.GE21220@suse.de>
 <002601cb3926$edaf24d0$66f8800a@maildom.okisemi.com>
 <20100811151510.GB9180@suse.de>
 <D5AB6E638E5A3E4B8F4406B113A5A19A28EA26B2@shsmsx501.ccr.corp.intel.com>
 <20100812020027.GA14121@suse.de>
In-Reply-To: <20100812020027.GA14121@suse.de>
Accept-Language: zh-CN, en-US
Content-Language: en-US
acceptlanguage: zh-CN, en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 2278
Lines: 61

> -----Original Message-----
> From: Greg KH [mailto:gregkh@suse.de]
> Sent: Thursday, August 12, 2010 10:00 AM
> To: Wang, Qi
> Cc: Masayuki Ohtake; meego-dev@meego.com; LKML; Wang, Yong Y; Khor,
> Andrew Chih Howe; arjan@linux.intel.com
> Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to
> 2.6.35
> 
> On Thu, Aug 12, 2010 at 09:13:24AM +0800, Wang, Qi wrote:
> > > -----Original Message-----
> > > From: Greg KH [mailto:gregkh@suse.de]
> > > Sent: Wednesday, August 11, 2010 11:15 PM
> > > To: Masayuki Ohtake
> > > Cc: meego-dev@meego.com; LKML; Wang, Qi; Wang, Yong Y; Khor, Andrew
> > > Chih Howe; arjan@linux.intel.com
> > > Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to
> > > 2.6.35
> > >
> > > On Wed, Aug 11, 2010 at 04:29:25PM +0900, Masayuki Ohtake wrote:
> > > > Hi Greg,
> > > >
> > > > > Do they all have to be ioctls?  What exactly are they doing?
> > > > I think using ioctl is common for this patch.
> > >
> > > "Common" is not ok, right?
> > >
> > > > Do you think that using ioctl is NOT appropriate for this patch?
> > >
> > > Yes.
> > >
> > > > Let me know your intension in more detail.
> > >
> > > Please express yours.  Why do you feel you need these to be ioctls?
> > > What exactly are they doing?  Where is the documentation for them all?
> 
> You forgot to answer this.
Ohtake-san,

Please answer this question asap.
> 
> > > > > And are they 32/64bit safe?
> > > > Only 32bit support.
> > >
> > > That's an obvious problem that needs to be resolved, right?
> > The Tunnelcreak processor (A kind of Atom-based processor) only
> > supports 32b, so PCH drivers only support 32b.
> > They can make it 32/64 compatible, but it's difficult to test them,
> > because there're no 64b Atom-based platform have those PCH devices.
> 
> But that does not mean you should not be using the proper types and
> other things necessary for proper ioctl usage.
> 
> As you failed to describe what any of these ioctls do, I can't recommend
> that you have any of them in the driver.
Ohtake-san, Please solve 32b/64b safe issue asap.
> 
> sorry,
> 
> greg k-h
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?