Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933669Ab0HLOaN (ORCPT ); Thu, 12 Aug 2010 10:30:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11811 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753875Ab0HLOaK (ORCPT ); Thu, 12 Aug 2010 10:30:10 -0400 Message-ID: <4C6405CA.3080701@redhat.com> Date: Thu, 12 Aug 2010 10:31:38 -0400 From: Peter Jones User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1 MIME-Version: 1.0 To: Randy Dunlap CC: Stephen Rothwell , Konrad Rzeszutek Wilk , linux-next@vger.kernel.org, LKML , scsi Subject: Re: [PATCH -next] firmware: ibft depends on SCSI References: <20100811140009.6ff33109.sfr@canb.auug.org.au> <20100811103620.2d25d573.randy.dunlap@oracle.com> In-Reply-To: <20100811103620.2d25d573.randy.dunlap@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2055 Lines: 53 On 08/11/2010 01:36 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Prevent build errors when SCSI is not enabled: > > iscsi_ibft.c:(.init.text+0x548d): undefined reference to `iscsi_boot_create_initiator' > iscsi_ibft.c:(.init.text+0x54a9): undefined reference to `iscsi_boot_create_ethernet' > iscsi_ibft.c:(.init.text+0x54c5): undefined reference to `iscsi_boot_create_target' > iscsi_ibft.c:(.init.text+0x55ff): undefined reference to `iscsi_boot_destroy_kset' > iscsi_ibft.c:(.init.text+0x561e): undefined reference to `iscsi_boot_create_kset' > iscsi_ibft.c:(.exit.text+0xe2c): undefined reference to `iscsi_boot_destroy_kset' > > Signed-off-by: Randy Dunlap > Cc: Peter Jones > Cc: Konrad Rzeszutek Wilk This looks good to me, thanks for catching it. Signed-of-by: Peter Jones > --- > drivers/firmware/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20100811.orig/drivers/firmware/Kconfig > +++ linux-next-20100811/drivers/firmware/Kconfig > @@ -125,7 +125,7 @@ config ISCSI_IBFT_FIND > config ISCSI_IBFT > tristate "iSCSI Boot Firmware Table Attributes module" > select ISCSI_BOOT_SYSFS > - depends on ISCSI_IBFT_FIND > + depends on ISCSI_IBFT_FIND && SCSI > default n > help > This option enables support for detection and exposing of iSCSI > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Peter RFC 882 put the dots in .com. 01234567890123456789012345678901234567890123456789012345678901234567890123456789 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/