Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759068Ab0HLVCR (ORCPT ); Thu, 12 Aug 2010 17:02:17 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:32905 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754924Ab0HLVCQ (ORCPT ); Thu, 12 Aug 2010 17:02:16 -0400 MIME-Version: 1.0 In-Reply-To: References: <201008122200.05598.thomas@m3y3r.de> From: Linus Torvalds Date: Thu, 12 Aug 2010 14:01:50 -0700 Message-ID: Subject: Re: 2.6.36: Sound stop working To: Pekka Enberg , Eric Paris , Al Viro Cc: Thomas Meyer , Linux Kernel Mailing List , Takashi Iwai Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1049 Lines: 25 On Thu, Aug 12, 2010 at 1:20 PM, Linus Torvalds wrote: > > So I suspect it's not sound that is broken at all, but pulseaudio that > got broken by the fanotify changes. Confirmed. That broken commit 3bcf3860a4ff9bb doesn't even boot for me (looks like a stack smash recursion), and the commit to "fix" it (c1e5c954020e12) is really too ugly to live. I think we need to totally undo the whole "struct file" thing, and just admit that it was a mistake. The code really wants a "struct path", and using a struct file screws up all the refcounting and is just not right. The fact that dentry_open() may have some problem needs to be fixed -there- rather than make the callers do crazy things that they don't want to do and can't do sanely. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/