Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761760Ab0HMPPT (ORCPT ); Fri, 13 Aug 2010 11:15:19 -0400 Received: from netrider.rowland.org ([192.131.102.5]:45104 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1761665Ab0HMPPR (ORCPT ); Fri, 13 Aug 2010 11:15:17 -0400 Date: Fri, 13 Aug 2010 11:15:15 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: David Brownell cc: linux-usb@vger.kernel.org, Greg KH , Michal Nazarewicz , Subject: Re: [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite In-Reply-To: <449572.54202.qm@web180316.mail.gq1.yahoo.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 22 On Thu, 12 Aug 2010, David Brownell wrote: > Looks OK, but I can't test or give it > a detailed review just now. An ACK from > Alan would be nice. There's nothing obviously wrong with this change. However based on all the preceding discussion, I now think the best approach may be _never_ to make up a fake serial number. Use the module parameter, if any, and otherwise issue a warning and don't have a serial number string descriptor (even though that violates the spec). At this point it should be easy to write a patch to implement and document the new behavior, for both file-storage and mass-storage. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/