DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=dLKPS+JdCyEFfbu8f/4Wo3avopENIRnFqm1PI7cESnwDikZo/0KD3ipkXHXQaOEyc7w6Jlkd1R4wWijgsJngRQMdGdpHdACOMxaeiwLnIRDkP1rZFLc17ShK0ZIndHKuOPp3AnADSJ6iMZofvvSzQpr0IUSaaz9oMGfs+DdYk7U=;
Message-ID: <920296.5376.qm@web180304.mail.gq1.yahoo.com>
Date: Fri, 13 Aug 2010 13:30:26 -0700 (PDT)
From: David Brownell <david-b@pacbell.net>
Subject: Re: [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org, Greg KH <greg@kroah.com>,
        Michal Nazarewicz <m.nazarewicz@samsung.com>,
        linux-kernel@vger.kernel.org
In-Reply-To: <Pine.LNX.4.44L0.1008131110130.12397-100000@netrider.rowland.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 756
Lines: 26


--- On Fri, 8/13/10, Alan Stern <stern@rowland.harvard.edu> wrote:
.?
> ... based on all
> the preceding discussion, I now think the best
> approach may be _never
> to make up a fake serial number.? Use the module
> parameter, if any, and
> otherwise issue a warning and don't have
> a serial number string
> descriptor (even though that violates the spec).


Agreed, and that's what I had asked for.  I didn't
see code faking up a serial ... did I miss such?

If so, let's see a new patch with no faking.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/