Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758613Ab0HOR7a (ORCPT ); Sun, 15 Aug 2010 13:59:30 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53280 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008Ab0HOR73 (ORCPT ); Sun, 15 Aug 2010 13:59:29 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Linus Torvalds Date: Sun, 15 Aug 2010 10:58:36 -0700 Message-ID: Subject: Re: [PATCH] mm: code improvement of check_stack_guard_page To: jovi zhang Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 857 Lines: 20 On Sat, Aug 14, 2010 at 10:15 PM, jovi zhang wrote: > > little code improvement of check_stack_guard_page function. > this commit is on top of commit "mm: keep a guard page below a > grow-down stack segment" of linus. I don't think your patch is in any way wrong, but I just checked, and it makes absolutely zero difference to the code generation at least for my version of gcc. The resulting assembly is identical except for the line numbers that changed (BUG_ON() line/file information and debug information). So I think I prefer the shallower indentation. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/