Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754573Ab0HPOzJ (ORCPT ); Mon, 16 Aug 2010 10:55:09 -0400 Received: from esgaroth.petrovitsch.at ([78.47.184.11]:4617 "EHLO esgaroth.petrovitsch.priv.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754233Ab0HPOzH (ORCPT ); Mon, 16 Aug 2010 10:55:07 -0400 X-DKIM: Sendmail DKIM Filter v2.8.3 unknown-host o7GEscBr015693 Subject: Re: [PATCH] perf tools: Don't use brace expansion. From: Bernd Petrovitsch To: Peter Zijlstra Cc: Kusanagi Kouichi , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org In-Reply-To: <1281969043.1926.1469.camel@laptop> References: <20100816124101.1829415C039@msa104.auone-net.jp> <1281967761.17267.6.camel@thorin> <1281969043.1926.1469.camel@laptop> Content-Type: text/plain; charset="UTF-8" Date: Mon, 16 Aug 2010 16:54:38 +0200 Message-ID: <1281970478.17267.12.camel@thorin> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-Transfer-Encoding: 7bit X-DCC-dcc1-Metrics: esgaroth.petrovitsch.priv.at; whitelist Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 30 On Mon, 2010-08-16 at 16:30 +0200, Peter Zijlstra wrote: > On Mon, 2010-08-16 at 16:09 +0200, Bernd Petrovitsch wrote: > > > > -$(shell sh -c 'mkdir -p $(OUTPUT)scripts/{perl,python}/Perf-Trace-Util/' 2> /dev/null) > > > -$(shell sh -c 'mkdir -p $(OUTPUT)util/{ui/browsers,scripting-engines}/' 2> /dev/null) > > > The other solution is to use standard-make features like in > > mkdir -p $(foreach d,ui/browsers scripting-engines,$(OUTPUT)util/$(d)/) 2> /dev/null > > > > Is there actually a specific reason for the > > $(shell sh -c '...') > > around? > > It looks superflous. > > I think the reason is is that nobody who touched that file really knew > make all that well. Your version looks fine to me. Ah, the reason is that they are not part of a rule but on the top-level (and thus always executed). Bernd -- Bernd Petrovitsch Email : bernd@petrovitsch.priv.at LUGA : http://www.luga.at -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/