Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754598Ab0HPPOl (ORCPT ); Mon, 16 Aug 2010 11:14:41 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:45615 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754503Ab0HPPOj convert rfc822-to-8bit (ORCPT ); Mon, 16 Aug 2010 11:14:39 -0400 Date: Mon, 16 Aug 2010 08:12:39 -0700 From: Randy Dunlap To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, "'Andrew Morton'" , "'Maxim Levitsky'" , ben-linux@fluff.org Subject: Re: undefined reference to `mmc_pm_notify' when selected MMC without PM. Message-Id: <20100816081239.c5ae02ef.randy.dunlap@oracle.com> In-Reply-To: <20100816051721.GA17903@pengutronix.de> References: <009801cb3adb$6550e400$2ff2ac00$%kim@samsung.com> <20100816051721.GA17903@pengutronix.de> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2168 Lines: 64 On Mon, 16 Aug 2010 07:17:21 +0200 Uwe Kleine-K?nig wrote: > Hello, > > On Fri, Aug 13, 2010 at 08:33:40PM +0900, Kukjin Kim wrote: > > Kukjin Kim wrote: > > > > > > Hi, > > > > > > Following is build error when selected MMC without PM. > > > > > > drivers/built-in.o: In function `mmc_alloc_host': > > > drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify' > > > make[1]: *** [.tmp_vmlinux1] Error 1 > > > make: *** [sub-make] Error 2 > > > > > > That is added from Maxim's ' mmc: fix all hangs related to mmc/sd card > > > insert/removal during suspend/resume ' > > > (commit ID: 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e) > > > > > > Below is temporary patch for avoiding build error. > > > But I'm not sure about this... :-( > > > > > > --- > > > > > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > > > index 0efe631..d80cfdc 100644 > > > --- a/drivers/mmc/core/host.c > > > +++ b/drivers/mmc/core/host.c > > > @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device > > > *dev) > > > init_waitqueue_head(&host->wq); > > > INIT_DELAYED_WORK(&host->detect, mmc_rescan); > > > INIT_DELAYED_WORK_DEFERRABLE(&host->disable, > > > mmc_host_deeper_disable); > > > +#ifdef CONFIG_PM > > > host->pm_notify.notifier_call = mmc_pm_notify; > > > +#endif > > > > > > /* > > > * By default, hosts do not support SGIO or large requests. > > > > > > --- > > > > Kindly ignore this stuff because I found Uwe's same patch just now ;-) > > Sorry for bothering. > For those who care: > > http://mid.gmane.org/1281691473-15481-1-git-send-email-u.kleine-koenig@pengutronix.de > > Kgene, do you care to ack this change as it may prod akpm in taking the > fix a bit earlier? or this one from earlier: http://lkml.org/lkml/2010/8/12/207 --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/