Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754590Ab0HPPgo (ORCPT ); Mon, 16 Aug 2010 11:36:44 -0400 Received: from xenotime.net ([72.52.115.56]:39783 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751823Ab0HPPgn (ORCPT ); Mon, 16 Aug 2010 11:36:43 -0400 Date: Mon, 16 Aug 2010 08:36:37 -0700 From: Randy Dunlap To: Ernst Schwab Cc: spi-devel-general@lists.sourceforge.net, lkml , David Brownell , Grant Likely Subject: Re: spi.h: missing kernel-doc notation, please fix Message-Id: <20100816083637.ca01e53e.rdunlap@xenotime.net> In-Reply-To: <20100816151011.68e6c722.eschwab@online.de> References: <20100815103156.37ae14cd.rdunlap@xenotime.net> <20100816151011.68e6c722.eschwab@online.de> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1796 Lines: 48 On Mon, 16 Aug 2010 15:10:11 +0200 Ernst Schwab wrote: > Added comments in kernel-doc notation for previously added struct fields. > > Signed-off-by: Ernst Schwab Thanks. Acked-by: Randy Dunlap > --- > On Sun, 15 Aug 2010 10:31:56 -0700 > Randy Dunlap wrote: > > > This patch in mainline: > > > > commit cf32b71e981ca63e8f349d8585ca2a3583b556e0 > > Author: Ernst Schwab > > Date: Mon Jun 28 17:49:29 2010 -0700 > > > > spi/mmc_spi: SPI bus locking API, using mutex > > > > adds some struct fields but does not add kernel-doc notation for them. > > Please add that missing struct documentation. > > diff a/include/linux/spi/spi.h b/include/linux/spi/spi.h > --- a/include/linux/spi/spi.h > +++ b/include/linux/spi/spi.h > @@ -213,6 +213,9 @@ static inline void spi_unregister_driver > * @dma_alignment: SPI controller constraint on DMA buffers alignment. > * @mode_bits: flags understood by this controller driver > * @flags: other constraints relevant to this driver > + * @bus_lock_spinlock: spinlock for SPI bus locking > + * @bus_lock_mutex: mutex for SPI bus locking > + * @bus_lock_flag: indicates that the SPI bus is locked for exclusive use > * @setup: updates the device mode and clocking records used by a > * device's SPI controller; protocol code may call this. This > * must fail if an unrecognized or unsupported mode is requested. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/