Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755188Ab0HPQgr (ORCPT ); Mon, 16 Aug 2010 12:36:47 -0400 Received: from mail.tmr.com ([64.65.253.246]:60776 "EHLO partygirl.tmr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754642Ab0HPQgm (ORCPT ); Mon, 16 Aug 2010 12:36:42 -0400 Message-ID: <4C6968D3.4040108@tmr.com> Date: Mon, 16 Aug 2010 12:35:31 -0400 From: Bill Davidsen User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.21) Gecko/20090507 Fedora/1.1.16-1.fc9 NOT Firefox/3.0.11 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Takashi Iwai CC: Shaohua Li , Trond.Myklebust@netapp.com, rjw@sisk.pl, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: nfs regression 2.6.35+ References: <20100816070626.GA10503@sli10-desk.sh.intel.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2469 Lines: 74 Takashi Iwai wrote: > At Mon, 16 Aug 2010 12:09:12 +0200, Takashi Iwai wrote: >> At Mon, 16 Aug 2010 15:06:26 +0800, >> Shaohua Li wrote: >>> NFS client runs latest git. At client side, use vim to edit a file located at >>> NFS server. If I save the file, vim always reports 'E667: Fsync failed'. If I >>> revert f7fa16506bf9b6323e862a61e14c20555152bb3, vim works. No kernel errors >>> reported. >> This hits me, too. Reverting it cures the problem. >> (BTW, the correct commit id of the affecting patch is >> af7fa16506bf9b6323e862a61e14c20555152bb3 >> "NFS: Fix up the fsync code") >> >> Reproduced on 2.6.36-rc1. >> >> Looking at strace output, >> >> open("afo", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 4 >> write(4, "#!/bin\n", 7) = 7 >> fsync(4) = 1 >> stat("afo", {st_mode=S_IFREG|0644, st_size=7, ...}) = 0 >> close(4) = 0 >> >> So, fsync() returns 1 wrongly. > > How about a band-aid fix below? > Your band-aid sticks for me. > > Takashi > > > From c75eab5ac47f5ce27a0d450423f8c46824f832f0 Mon Sep 17 00:00:00 2001 > From: Takashi Iwai > Date: Mon, 16 Aug 2010 12:25:19 +0200 > Subject: [PATCH] NFS: fix fsync return code > > With the commit af7fa16506bf9b6323e862a61e14c20555152bb3 > NFS: Fix up the fsync code > fsync returns a postive number for success incorrectly because now it > calls nfs_commit_inode() which returns the number of pages. > > This patch makes fsync simply ignore a positive return value. > > Signed-off-by: Takashi Iwai > --- > fs/nfs/file.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/nfs/file.c b/fs/nfs/file.c > index 2d141a7..eb51bd6 100644 > --- a/fs/nfs/file.c > +++ b/fs/nfs/file.c > @@ -323,7 +323,7 @@ nfs_file_fsync(struct file *file, int datasync) > have_error |= test_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags); > if (have_error) > ret = xchg(&ctx->error, 0); > - if (!ret) > + if (!ret && status < 0) > ret = status; > return ret; > } -- Bill Davidsen "We have more to fear from the bungling of the incompetent than from the machinations of the wicked." - from Slashdot -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/