Date: Mon, 16 Aug 2010 14:17:51 -0400
From: Nick Bowler <nbowler@elliptictech.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Shaohua Li <shaohua.li@intel.com>, Trond.Myklebust@netapp.com, rjw@sisk.pl,
        linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: nfs regression 2.6.35+
Message-ID: <20100816181751.GA2439@elliptictech.com>
Mail-Followup-To: Takashi Iwai <tiwai@suse.de>,
	Shaohua Li <shaohua.li@intel.com>, Trond.Myklebust@netapp.com,
	rjw@sisk.pl, linux-kernel@vger.kernel.org,
	linux-nfs@vger.kernel.org
References: <20100816070626.GA10503@sli10-desk.sh.intel.com>
 <s5h39uedg3b.wl%tiwai@suse.de>
 <s5hfwyelu28.wl%tiwai@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <s5hfwyelu28.wl%tiwai@suse.de>
Organization: Elliptic Technologies Inc.
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1003
Lines: 30

On 2010-08-16 12:40 +0200, Takashi Iwai wrote:
> At Mon, 16 Aug 2010 12:09:12 +0200, Takashi Iwai wrote:
> > This hits me, too.  Reverting it cures the problem.
> > (BTW, the correct commit id of the affecting patch is
> >  af7fa16506bf9b6323e862a61e14c20555152bb3
> >  "NFS: Fix up the fsync code")
> > 
> > Reproduced on 2.6.36-rc1.
> > 
> > So, fsync() returns 1 wrongly.

Apparently this breaks NFS file locks as well:  

  fetchmail: starting fetchmail 6.3.17 daemon
  /home/nbowler/.fetchmail.pid: Bad file descriptor
  fetchmail: lock creation failed.

> How about a band-aid fix below?
[...]
> Subject: [PATCH] NFS: fix fsync return code

and this fixes all the problems for me.

-- 
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/