Message-ID: <4C69ABE6.6030309@s5r6.in-berlin.de>
Date: Mon, 16 Aug 2010 23:21:42 +0200
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.23) Gecko/20100627 SeaMonkey/1.1.18
MIME-Version: 1.0
To: linux1394-devel@lists.sourceforge.net
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firewire: sbp2: fix stall with "Unsolicited response"
References: <tkrat.330c42bb8ceb6a7a@s5r6.in-berlin.de> <tkrat.d1f4cde2efe6d756@s5r6.in-berlin.de>
In-Reply-To: <tkrat.d1f4cde2efe6d756@s5r6.in-berlin.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 938
Lines: 21

Stefan Richter wrote:
> The stalls happen during heavy or moderate disk traffic in periods that
> are a multiple of 5 minutes, roughly twice per hour.  They are caused
> by the target responding too late to an ORB_Pointer register write
[and subsequent SCSI error handling.]
> So let's just ignore RCODE_CANCELLED in the transaction callback and
> wait for the target to complete the ORB nevertheless.

PS:  This is not only about the stalls.  It is also to prevent memory
corruption that may happen when the target writes to SCSI request
buffers after they were unmapped and freed, although this does not
appear likely to me.
-- 
Stefan Richter
-=====-==-=- =--- =----
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/