Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753546Ab0HQHqU (ORCPT ); Tue, 17 Aug 2010 03:46:20 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:36883 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940Ab0HQHqS convert rfc822-to-8bit (ORCPT ); Tue, 17 Aug 2010 03:46:18 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Udm+WWNYF/n6g23YWRhDvbITuhEmH/dzU0PaRYnufKR2yKhyNqPDuiK2IZgSH0DjHx vuY4N6g7+WQECXiVLmXmwJUmKd9qfpXns3ixpIZ6XVnjEn4p6Fqf+MHIqhVvKllmcanm UvsOylglgwJUsdZIQWzZ93krC7uYZ7j5susBc= MIME-Version: 1.0 In-Reply-To: References: <20100812162218.GA21286@core.coreip.homeip.net> Date: Tue, 17 Aug 2010 09:46:17 +0200 X-Google-Sender-Auth: -yfKwA92ajUX13uEgdzi2-hQf_g Message-ID: Subject: Re: [PATCH] Input: fix faulty XXinput_* calls From: Geert Uytterhoeven To: Dmitry Torokhov Cc: Linus Torvalds , Daniel Mack , Andrew Morton , LKML Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2135 Lines: 52 On Sat, Aug 14, 2010 at 23:52, Geert Uytterhoeven wrote: > On Thu, Aug 12, 2010 at 18:22, Dmitry Torokhov > wrote: >> From: Daniel Mack >> >> They've been introduced by 987a6c02 ("Input: switch to input_abs_*() >> access functions") and they appear to be some kind of debug left-over. >> >> [Dmitry Torokhov: these are my fault - I added XX prefixes in places where >>  I wanted to do additional review of the code but failed to actually do >>  that in these particular instances.] >> >> Signed-off-by: Daniel Mack >> Signed-off-by: Dmitry Torokhov >> --- >> >>  drivers/input/joystick/amijoy.c  |    2 +- > > Thanks, amijoy.c compiles now. > > But hil_kbd.c still doesn't compile: > >> diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c >> index ddd5afd..dcc86b9 100644 >> --- a/drivers/input/keyboard/hil_kbd.c >> +++ b/drivers/input/keyboard/hil_kbd.c >> @@ -235,7 +235,7 @@ static void hil_dev_handle_ptr_events(struct hil_dev *ptr) >>                        if (val < input_abs_min(dev, ABS_X + i)) >>                                input_abs_set_min(dev, ABS_X + i, val); >>                        if (val > input_abs_max(dev, ABS_X + i)) > > error: implicit declaration of function ‘input_abs_max’. > > And indeed, input_abs_max() does not exist, while hil_kbd.c has 4 callers. Ping? What should these input_abs_max() calls be? Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/