Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755957Ab0HQJw2 (ORCPT ); Tue, 17 Aug 2010 05:52:28 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:55363 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751148Ab0HQJw1 (ORCPT ); Tue, 17 Aug 2010 05:52:27 -0400 Date: Tue, 17 Aug 2010 11:07:33 +0100 From: Alan Cox To: Dan Carpenter Cc: Bartlomiej Zolnierkiewicz , Jeff Garzik , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] pata_winbond: fix module init Message-ID: <20100817110733.1c57aedd@lxorguk.ukuu.org.uk> In-Reply-To: <20100817062830.GF645@bicker> References: <20100803152549.GQ26313@bicker> <201008162123.03208.bzolnier@gmail.com> <20100817062830.GF645@bicker> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1090 Lines: 30 On Tue, 17 Aug 2010 08:29:40 +0200 Dan Carpenter wrote: > On Mon, Aug 16, 2010 at 09:23:03PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > > Hi Dan, > > > > On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote: > > > winbond_init_one() returns 0 on success and an error code on failure. > > > In the original code, we always just released the regions and return > > > -ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata: > > > Winbond support". > > > > You might like to pick up > > > > http://patchwork.ozlabs.org/patch/39358/ > > > > instead.. > > > > I don't have the hardware, but yes, probably it's better to replace this > driver since it has never been able to load. It was obsoleted into pata_legacy before it was ever finalised - unfortunately I could then not get Jeff to delete it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/