Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755730Ab0HQNZG (ORCPT ); Tue, 17 Aug 2010 09:25:06 -0400 Received: from cantor.suse.de ([195.135.220.2]:39020 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752901Ab0HQNZF (ORCPT ); Tue, 17 Aug 2010 09:25:05 -0400 Date: Tue, 17 Aug 2010 06:07:40 -0700 From: Greg KH To: Masayuki Ohtake Cc: meego-dev@meego.com, LKML , "Wang, Yong Y" , "Khor, Andrew Chih Howe" , arjan@linux.intel.com, "Wang, Qi" Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35 Message-ID: <20100817130740.GA24564@suse.de> References: <4C612AA4.5040100@dsn.okisemi.com> <20100810171343.GE21220@suse.de> <002601cb3926$edaf24d0$66f8800a@maildom.okisemi.com> <20100811151510.GB9180@suse.de> <20100812020027.GA14121@suse.de> <001001cb3ddb$9929d9a0$66f8800a@maildom.okisemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001001cb3ddb$9929d9a0$66f8800a@maildom.okisemi.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 35 On Tue, Aug 17, 2010 at 04:12:45PM +0900, Masayuki Ohtake wrote: > > > > > On Wed, Aug 11, 2010 at 04:29:25PM +0900, Masayuki Ohtake wrote: > > > > > > Hi Greg, > > > > > > > > > > > > > Do they all have to be ioctls? What exactly are they doing? > > > > > > I think using ioctl is common for this patch. > > > > > > > > > > "Common" is not ok, right? > > > > > > > > > > > Do you think that using ioctl is NOT appropriate for this patch? > > > > > > > > > > Yes. > > > > > > > > > > > Let me know your intension in more detail. > > > > > > > > > > Please express yours. Why do you feel you need these to be ioctls? > > > > > What exactly are they doing? Where is the documentation for them all? > > > > > > You forgot to answer this. > > Ohtake-san, > > > > Please answer this question asap. > > Intel Topcliff IEEE1588 device driver API is developed according to Intel > Tolapai 1588 device driver. > Both APIs are the same. That _still_ did not answer the questions. Please answer them. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/