Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754397Ab0HQR0V (ORCPT ); Tue, 17 Aug 2010 13:26:21 -0400 Received: from mail.perches.com ([173.55.12.10]:1122 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752464Ab0HQR0P (ORCPT ); Tue, 17 Aug 2010 13:26:15 -0400 Subject: Re: [PATCH] fs.h: introduce functions to get/set file->private_data From: Joe Perches To: Christoph Hellwig Cc: "Ted Ts'o" , H Hartley Sweeten , Linux Kernel , "linux-fsdevel@vger.kernel.org" , "matthew@wil.cx" In-Reply-To: <20100817085428.GA25330@infradead.org> References: <201008161137.53187.hartleys@visionengravers.com> <20100816231753.GA16546@infradead.org> <0D753D10438DA54287A00B0270842697643E50D82E@AUSP01VMBX24.collaborationhost.net> <1282002601.6518.116.camel@Joe-Laptop> <20100817010355.GG21182@thunk.org> <20100817085428.GA25330@infradead.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 17 Aug 2010 10:26:13 -0700 Message-ID: <1282065973.24541.106.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 813 Lines: 21 On Tue, 2010-08-17 at 04:54 -0400, Christoph Hellwig wrote: > On Mon, Aug 16, 2010 at 09:03:55PM -0400, Ted Ts'o wrote: > > And spatch could also be used to rename private_data to f_private_data > > if people really cared.... > Agreed, that's much better than adding useless accessors. Against Linus' current, it's ~850KB. Anyone really want it? $ git diff --shortstat 495 files changed, 2526 insertions(+), 2529 deletions(-) $ git diff --stat -p > f_private_data.diff $ ls -la f_private_data.diff -rw-r--r-- 1 joe joe 853136 2010-08-17 10:19 f_private_data.diff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/