Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758071Ab0HQSFR (ORCPT ); Tue, 17 Aug 2010 14:05:17 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:39490 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772Ab0HQSFP (ORCPT ); Tue, 17 Aug 2010 14:05:15 -0400 Message-ID: <4C6ACEFB.7060706@oracle.com> Date: Tue, 17 Aug 2010 11:03:39 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Laurent Pinchart CC: Stephen Rothwell , gregkh@suse.de, lud , linux-next@vger.kernel.org, LKML , David Brownell Subject: Re: [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again References: <20100809132314.789e13f3.sfr@canb.auug.org.au> <201008101416.31188.laurent.pinchart@ideasonboard.com> <4C6166D9.60607@oracle.com> <201008101653.08358.laurent.pinchart@ideasonboard.com> In-Reply-To: <201008101653.08358.laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3001 Lines: 65 On 08/10/10 07:53, Laurent Pinchart wrote: > Hi Randy, > > On Tuesday 10 August 2010 16:48:57 Randy Dunlap wrote: >> On 08/10/10 05:16, Laurent Pinchart wrote: >>> On Monday 09 August 2010 19:55:20 Randy Dunlap wrote: >>>> From: Randy Dunlap >>>> >>>> The USB gadget webcam driver uses V4L2 interfaces, so it should depend >>>> on VIDEO_V4L2 instead of VIDEO_DEV. This fixes a lot of build errors >>>> when V4L2 is not enabled: >>>> >>>> ERROR: "v4l2_event_unsubscribe" [drivers/usb/gadget/g_webcam.ko] >>>> undefined! ERROR: "v4l2_event_queue" [drivers/usb/gadget/g_webcam.ko] >>>> undefined! ERROR: "video_device_release" >>>> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: "video_usercopy" >>>> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: "v4l2_event_dequeue" >>>> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: >>>> "video_register_device" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "video_device_alloc" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_event_subscribe" [drivers/usb/gadget/g_webcam.ko] >>>> undefined! ERROR: "video_unregister_device" >>>> [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_fh_init" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_event_pending" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_event_init" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "video_devdata" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_event_alloc" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_fh_add" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_fh_del" [drivers/usb/gadget/g_webcam.ko] undefined! >>>> ERROR: "v4l2_fh_exit" [drivers/usb/gadget/g_webcam.ko] undefined! >>> >>> All those symbols should be defined when VIDEO_DEV is selected. >>> >>>> ERROR: "v4l2_ctrl_fill" [drivers/media/video/v4l2-common.ko] undefined! >>>> ERROR: "v4l2_ctrl_get_menu" [drivers/media/video/v4l2-common.ko] >>>> undefined! >>> >>> Those 2 symbols require VIDEO_V4L2 but are not used by the webcam gadget >>> driver. >>> >>>> ERROR: "v4l2_device_unregister_subdev" >>>> [drivers/media/video/v4l2-common.ko] undefined! >>>> ERROR: "v4l2_device_register_subdev" >>>> [drivers/media/video/v4l2-common.ko] undefined! >>> >>> Those two symbols should be defined when VIDEO_DEV is selected. They are >>> not used by the webcam gadget driver. >> >> Summary: I should drop this patch and look elsewhere for the problem, >> Right? > > I think the problem comes from somewhere else, yes. Your patch won't hurt, but > I don't see how it could fix the problem either. Agreed. Patch is withdrawn. Thanks. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/