Return-Path: <linux-kernel-owner+akpm=40zip.com.au@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S316579AbSFDIww>; Tue, 4 Jun 2002 04:52:52 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S316580AbSFDIwv>; Tue, 4 Jun 2002 04:52:51 -0400
Received: from [195.63.194.11] ([195.63.194.11]:28934 "EHLO
	mail.stock-world.de") by vger.kernel.org with ESMTP
	id <S316579AbSFDIwu>; Tue, 4 Jun 2002 04:52:50 -0400
Message-ID: <3CFC7226.2010101@evision-ventures.com>
Date: Tue, 04 Jun 2002 09:54:14 +0200
From: Martin Dalecki <dalecki@evision-ventures.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.0rc3) Gecko/20020523
X-Accept-Language: en-us, pl
MIME-Version: 1.0
To: Russell King <rmk@arm.linux.org.uk>
CC: Jens Axboe <axboe@suse.de>, Linus Torvalds <torvalds@transmeta.com>,
        linux-kernel@vger.kernel.org
Subject: Re: PATCH/RFC: fix 2.5.20 ramdisk
In-Reply-To: <20020603180627.A23056@flint.arm.linux.org.uk> <20020604083525.GA2512@suse.de> <20020604094532.A30552@flint.arm.linux.org.uk>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Russell King wrote:
> On Tue, Jun 04, 2002 at 10:35:25AM +0200, Jens Axboe wrote:
> 
>>On Mon, Jun 03 2002, Russell King wrote:
>>
>>>2.5.20 seems to be incapable of executing binaries in a ramdisk-based
>>>root filesystem.  The ramdisk in question is an ext2fs, with a 1K
>>>block size loaded via the compressed ramdisk loader in do_mounts().
>>>
>>>It appears that, in the case of a 1K block sized filesystem, we attempt
>>>to read two 512-byte sectors into a BIO vector.  The first one is copied
>>>into the first 512 bytes.  The second sector, however, is copied over
>>>the first 512 bytes.  Obviously not what we really want.
>>
>>Looks good.
> 
> 
> Ok, rev. 2, slightly cleaned up:
> 
> --- orig/drivers/block/rd.c	Wed May 29 21:40:26 2002
> +++ linux/drivers/block/rd.c	Tue Jun  4 09:44:21 2002
> @@ -144,6 +144,7 @@
>  {
>  	struct address_space * mapping;
>  	unsigned long index;
> +	unsigned int vec_offset;


Just a small nit. Shouldn't taht be size_t ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/