Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436Ab0HREem (ORCPT ); Wed, 18 Aug 2010 00:34:42 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:50898 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961Ab0HREef convert rfc822-to-8bit (ORCPT ); Wed, 18 Aug 2010 00:34:35 -0400 MIME-Version: 1.0 In-Reply-To: <20100817044834.GA27060@angua.secretlab.ca> References: <1281095419-15600-1-git-send-email-linus.walleij@stericsson.com> <20100817044834.GA27060@angua.secretlab.ca> From: Grant Likely Date: Tue, 17 Aug 2010 22:34:15 -0600 X-Google-Sender-Auth: b3i9l6NYf6oerEVTLdKcgdAcKxw Message-ID: Subject: Re: [PATCH 1/5] ARM: add PrimeCell generic DMA to PL022 v9 To: Linus Walleij Cc: Dan Williams , linux-arm-kernel@lists.infradead.org, yuanyabin1978@sina.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2937 Lines: 71 On Mon, Aug 16, 2010 at 10:48 PM, Grant Likely wrote: > On Fri, Aug 06, 2010 at 01:50:19PM +0200, Linus Walleij wrote: >> This extends the PL022 SSP/SPI driver with generic DMA engine >> support using the PrimeCell DMA engine interface. Also fix up the >> test code for the U300 platform. >> >> Acked-by: Grant Likely >> Signed-off-by: Linus Walleij > > Applied to my next-spi branch. ?Thanks Hi Linus, This patch causes the following build error and warnings. The warnings are simple init annotation mismatches. I haven't dug into the error, but I suspect the driver needs to depend on or select another config symbol. I'm dropping it from my tree. g. LD drivers/spi/built-in.o WARNING: drivers/spi/built-in.o(.devinit.text+0x1a8): Section mismatch in reference from the function pl022_probe() to the function .init.text:pl022_dma_probe() The function __devinit pl022_probe() references a function __init pl022_dma_probe(). If pl022_dma_probe is only used by pl022_probe then annotate pl022_dma_probe with a matching annotation. LD drivers/built-in.o WARNING: drivers/built-in.o(.devinit.text+0x1a8): Section mismatch in reference from the function pl022_probe() to the function .init.text:pl022_dma_probe() The function __devinit pl022_probe() references a function __init pl022_dma_probe(). If pl022_dma_probe is only used by pl022_probe then annotate pl022_dma_probe with a matching annotation. LD vmlinux.o MODPOST vmlinux.o WARNING: vmlinux.o(.devinit.text+0x1a8): Section mismatch in reference from the function pl022_probe() to the function .init.text:pl022_dma_probe() The function __devinit pl022_probe() references a function __init pl022_dma_probe(). If pl022_dma_probe is only used by pl022_probe then annotate pl022_dma_probe with a matching annotation. GEN .version CHK include/generated/compile.h UPD include/generated/compile.h CC init/version.o LD init/built-in.o LD .tmp_vmlinux1 drivers/built-in.o: In function `pl022_dma_remove': hid-input.c:(.text+0x43434): undefined reference to `dma_release_channel' hid-input.c:(.text+0x43444): undefined reference to `dma_release_channel' drivers/built-in.o: In function `pl022_dma_probe': hid-input.c:(.init.text+0x244c): undefined reference to `__dma_request_channel' hid-input.c:(.init.text+0x2480): undefined reference to `__dma_request_channel' hid-input.c:(.init.text+0x24cc): undefined reference to `dma_release_channel' hid-input.c:(.init.text+0x2514): undefined reference to `dma_release_channel' make[1]: *** [.tmp_vmlinux1] Error 1 make: *** [sub-make] Error 2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/