Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751650Ab0HRFhG (ORCPT ); Wed, 18 Aug 2010 01:37:06 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:64718 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793Ab0HRFhD convert rfc822-to-8bit (ORCPT ); Wed, 18 Aug 2010 01:37:03 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=uGE2+hzfgAyPGfaa8h8jBXlZ/LiDDiVFiX2EtRCUjdM6zuVs3telLlKtnjJxcsXqu5 BsD3+OfqlWGh4jiBdcJ/Bc5CWhEDLpX1g3+1i1WvQ9qXZ0wEUwJbdC+p/vJjXG05BXgB QnlklVfd8fG0MSeJWUvdalK8CRqC77tnOxa3w= MIME-Version: 1.0 In-Reply-To: <4C6A2FC2.9050908@suse.cz> References: <1281592579-343-1-git-send-email-vapier@gentoo.org> <20100817054640.GD5095@cr0.nay.redhat.com> <4C6A2FC2.9050908@suse.cz> From: Mike Frysinger Date: Wed, 18 Aug 2010 01:36:41 -0400 X-Google-Sender-Auth: NKaDwSYh4MtmXcc500tPliusPcI Message-ID: Subject: Re: [PATCH] kconfig: fix warnings in fgets/fwrite usage To: Michal Marek Cc: =?UTF-8?Q?Am=C3=A9rico_Wang?= , linux-kbuild@vger.kernel.org, Roman Zippel , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 25 On Tue, Aug 17, 2010 at 02:44, Michal Marek wrote: > On 17.8.2010 07:46, Américo Wang wrote: >> On Thu, Aug 12, 2010 at 01:56:19AM -0400, Mike Frysinger wrote: >>> Add some helper functions that abort on failure, and change the fwrite >>> and fget calls to use those.  This should kill off all the ugly gcc >>> warnings that some distros emit about ignoring return values due to >>> usage of warn_unused_result attributes. >>> >>> Signed-off-by: Mike Frysinger >> >> Looks good to me, >> >> Acked-by: WANG Cong > > I already merged similar patches by Jean Sacren, see commits bf5e327 and > 4418a2b in kbuild-2.6.git. guess i should have posted the patches when i wrote them (March). oh well, as long as it's fixed ;). -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/