Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752867Ab0HRLaa (ORCPT ); Wed, 18 Aug 2010 07:30:30 -0400 Received: from adelie.canonical.com ([91.189.90.139]:35346 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752645Ab0HRLa1 (ORCPT ); Wed, 18 Aug 2010 07:30:27 -0400 Date: Wed, 18 Aug 2010 12:30:23 +0100 From: Andy Whitcroft To: Joe Perches Cc: Dave Jones , Linux Kernel , Andrew Morton Subject: Re: [PATCH] scripts/checkpatch.pl: Add additional attribute #defines Message-ID: <20100818113023.GR6193@shadowen.org> References: <20100811163505.GB26497@redhat.com> <1281547748.3976.41.camel@Joe-Laptop.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1281547748.3976.41.camel@Joe-Laptop.home> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 25 On Wed, Aug 11, 2010 at 10:29:08AM -0700, Joe Perches wrote: > On Wed, 2010-08-11 at 12:35 -0400, Dave Jones wrote: > > I just got this from a patch I merged.. > > > > ERROR: need consistent spacing around '*' (ctx:WxV) > > #121: FILE: arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c:113: > > +static struct pcc_cpu __percpu *pcc_cpu_info; > > ^ > > which doesn't seem right. > > Perhaps these need to be added to checkpatch. > > Signed-off-by: Joe Perches This one looks sane to me, I've pulled this into my tree. The version at the URL below should contain it for testing: http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/