Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752836Ab0HRNEs (ORCPT ); Wed, 18 Aug 2010 09:04:48 -0400 Received: from out1.smtp.messagingengine.com ([66.111.4.25]:34591 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627Ab0HRNEq (ORCPT ); Wed, 18 Aug 2010 09:04:46 -0400 X-Sasl-enc: 4on55+s0N70CFzw/41JzB4b/PacoHVw67VY8PBWp+QXt 1282136686 Message-ID: <4C6BDA7E.4080203@ladisch.de> Date: Wed, 18 Aug 2010 15:05:02 +0200 From: Clemens Ladisch User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: Stefan Richter CC: Peter Zijlstra , Yong Zhang , Johannes Berg , Thomas Gleixner , linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: lockdep false positive? -- firewire-core transaction timer vs. scsi-core host lock References: <20100817143509.GC2838@zhy> <4C6AB76C.9060809@s5r6.in-berlin.de> <4C6B8562.1070902@ladisch.de> <1282121942.1926.3552.camel@laptop> <4C6BA757.7050108@ladisch.de> In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 775 Lines: 25 Stefan Richter wrote: > Clemens Ladisch wrote: > > spin_lock_irqsave(&card->lock, flags); > > list_for_each_entry(t, &card->transaction_list, link) { > > if (t == transaction) { > > + if (!del_timer(&t->split_timeout_timer)) > > + goto timed_out; > > + if (!del_timer(&t->split_timeout_timer)) { > + spin_unlock_irqrestore(&card->lock, flags); > + goto timed_out; > + } > Shall I commit with the added spin_unlocks? I can obviously not be trusted to do this correctly; please go ahead. Regards, Clemens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/