Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752071Ab0HRTNW (ORCPT ); Wed, 18 Aug 2010 15:13:22 -0400 Received: from mga03.intel.com ([143.182.124.21]:42755 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465Ab0HRTNU (ORCPT ); Wed, 18 Aug 2010 15:13:20 -0400 Message-Id: <89k83a$9bjd6q@azsmga001.ch.intel.com> X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.56,228,1280732400"; d="scan'208";a="314160346" Date: Wed, 18 Aug 2010 20:13:12 +0100 To: maciej.rutecki@gmail.com, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie Subject: Re: [REGRESSION] [2.6.36-rc1] [DRM INTEL] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for plane, expect flickering: entries required = 36, available = 28. References: <201008182046.37732.maciej.rutecki@gmail.com> From: Chris Wilson In-Reply-To: <201008182046.37732.maciej.rutecki@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1627 Lines: 32 On Wed, 18 Aug 2010 20:46:37 +0200, Maciej Rutecki wrote: > Last known good: 2.6.35 > Failing kernel: 2.6.36-rc1 > > During boot kernel display this message: > [ 0.831906] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for plane, > expect flickering: entries required = 36, available = 28. To be honest, I was shocked at how often we were actually computing that we required a larger FIFO for scanout than was available. Typically, it is the result of the pessimistic latency we guess for the memory fetch and so we err on the side of extreme caution when computing the watermark. So in effect, we have been clamping the FIFO since the beginning, but we only just added the warning message as an aide to diagnosing some FIFO underruns. We could tone down the error message, the real goal though is to improve the accuracy of the calculation and thereby reduce power. > Systems seems work OK, but in 2.6.35 I don't have this message. On another > system with 2.6.36-rc1 kernel I have the same message. Yes, there was just a couple of places where we changed the calculation to round-up but otherwise the wm logic remained mostly the same. So if you haven't been experiencing FIFO underruns, e.g. the screen flickering, then it is likely that the error is benign (and just wasting power). -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/