Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751525Ab0HSIa1 (ORCPT ); Thu, 19 Aug 2010 04:30:27 -0400 Received: from filtteri1.pp.htv.fi ([213.243.153.184]:58370 "EHLO filtteri1.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927Ab0HSIaY (ORCPT ); Thu, 19 Aug 2010 04:30:24 -0400 Date: Thu, 19 Aug 2010 11:21:40 +0300 From: Alexander Shishkin To: Greg KH Cc: Andrew Morton , "H. Peter Anvin" , lkml@vger.kernel.org, "Kirill A. Shutemov" , Thomas Gleixner , John Stultz , Martin Schwidefsky , Jon Hunter , Ingo Molnar , Peter Zijlstra , "Paul E. McKenney" , David Howells , Avi Kivity , John Kacur , Chris Friesen , Kay Sievers , linux-kernel@vger.kernel.org, Alexander Shishkin Subject: Re: [PATCH] [RFCv2] notify userspace about time changes Message-ID: <20100819082140.GB3003@shisha.kicks-ass.net> Mail-Followup-To: Greg KH , Andrew Morton , "H. Peter Anvin" , lkml@vger.kernel.org, "Kirill A. Shutemov" , Thomas Gleixner , John Stultz , Martin Schwidefsky , Jon Hunter , Ingo Molnar , Peter Zijlstra , "Paul E. McKenney" , David Howells , Avi Kivity , John Kacur , Chris Friesen , Kay Sievers , linux-kernel@vger.kernel.org References: <1282139739-23832-1-git-send-email-virtuoso@slind.org> <20100818155702.bc62b2a6.akpm@linux-foundation.org> <4C6C7034.4050501@zytor.com> <20100818165303.dd52695a.akpm@linux-foundation.org> <20100819040937.GA8646@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100819040937.GA8646@suse.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 840 Lines: 25 On Wed, Aug 18, 2010 at 09:09:37 -0700, Greg KH wrote: > On Wed, Aug 18, 2010 at 04:53:03PM -0700, Andrew Morton wrote: > > Is sysfs the right interface for this thing? Bear in mind that > > CONFIG_SYSFS does exist. > > > > > + fd = open("/sys/kernel/time_notify", O_WRONLY); > > > + fdprintf(fd, "%d 1 0 1 1", efd); > > > > why not > > > > sys_time_notify(efd, 1, 0, 1, 1); > > Yeah, that would be much better than a sysfs file, this is abusing the > sysfs interface quite a lot. Hm, ok. I used to think that adding new syscalls was discouraged, though. Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/