Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751659Ab0HSIjD (ORCPT ); Thu, 19 Aug 2010 04:39:03 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:36322 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854Ab0HSIjA (ORCPT ); Thu, 19 Aug 2010 04:39:00 -0400 Date: Thu, 19 Aug 2010 04:38:39 -0400 From: Christoph Hellwig To: device-mapper development Cc: Tejun Heo , Vladislav Bolkhovitin , linux-kernel@vger.kernel.org, Bryan Mesich , Jens Axboe , linux-raid@vger.kernel.org, Jeff Moyer , scst-devel@lists.sourceforge.net, stable@kernel.org Subject: Re: [dm-devel] [PATCH RESEND 1/2 block#for-linus] bio, fs: update READA and SWRITE to match the corresponding BIO_RW_* bits Message-ID: <20100819083839.GA32336@infradead.org> References: <4C3EF3AD.5070509@vlnb.net> <20100723191844.GB31152@atlantis.cc.ndsu.nodak.edu> <4C4D7DF5.9060909@vlnb.net> <20100727220110.GF31152@atlantis.cc.ndsu.nodak.edu> <4C5073F3.1060406@vlnb.net> <4C52A98A.7060507@kernel.org> <20100802104227.79340b49@notabene> <4C56D30A.3000403@kernel.org> <4C5B89DB.5050106@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C5B89DB.5050106@oracle.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 805 Lines: 18 On Fri, Aug 06, 2010 at 12:04:43PM +0800, Tao Ma wrote: > >>Stable: The offending commit a82afdf was released with v2.6.32, so > >>this patch should be applied to all kernels since then but it must > >>_NOT_ be applied to kernels earlier than that. > If only this patch goes into stable, do we need to change RWA_MASK > in this patch also(I have seen you change it the 2/2)? > > -#define RWA_MASK 2 > +#define RWA_MASK 16 I think RW_MASK and RWA_MASK should simply go away, they don't server any use over just masking the correct REQ_* flags. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/