Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753205Ab0HSNAC (ORCPT ); Thu, 19 Aug 2010 09:00:02 -0400 Received: from one.firstfloor.org ([213.235.205.2]:34047 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752897Ab0HSM77 (ORCPT ); Thu, 19 Aug 2010 08:59:59 -0400 Date: Thu, 19 Aug 2010 14:59:57 +0200 From: Andi Kleen To: Bernd Petrovitsch Cc: Andi Kleen , Namhyung Kim , Arnd Bergmann , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] introduce ptr_diff() Message-ID: <20100819125957.GB6729@basil.fritz.box> References: <1282217856-8625-1-git-send-email-namhyung@gmail.com> <87aaoiu6z6.fsf@basil.nowhere.org> <1282222109.10440.50.camel@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1282222109.10440.50.camel@thorin> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 520 Lines: 15 > If so, the warning seems valid as sizeof(struct page) is probably not > (always) a power of 2. On a native build on x86_64 it is 56 bytes > hereover. > Hmm .... gcc just generats a mull with inverted value. mull is cheap on any reasonable CPU. Please fix sparse. -andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/