Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753532Ab0HSOZY (ORCPT ); Thu, 19 Aug 2010 10:25:24 -0400 Received: from smtp.nokia.com ([192.100.122.230]:17932 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753476Ab0HSOZU (ORCPT ); Thu, 19 Aug 2010 10:25:20 -0400 Message-ID: <4C6D3EED.7040703@nokia.com> Date: Thu, 19 Aug 2010 17:25:49 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 MIME-Version: 1.0 To: "Krogerus Heikki (EXT-Teleca/Helsinki)" CC: ext Anton Vorontsov , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "dwmw2@infradead.org" , "Balbi Felipe (Nokia-MS/Helsinki)" , "Palande Ameya (Nokia-MS/Helsinki)" , "Lehtonen Markus (Nokia-MS/Helsinki)" , Tony Lindgren Subject: Re: [PATCHv2 2/2] omap: rx51: add support for USB chargers References: <1282219777-17657-1-git-send-email-ext-heikki.krogerus@nokia.com> <1282219777-17657-3-git-send-email-ext-heikki.krogerus@nokia.com> <20100819124042.GA15837@oksana.dev.rtsoft.ru> <20100819130937.GC4363@esdhcp041123.research.nokia.com> In-Reply-To: <20100819130937.GC4363@esdhcp041123.research.nokia.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 19 Aug 2010 14:25:08.0133 (UTC) FILETIME=[53190550:01CB3FAA] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 25 On 08/19/2010 04:09 PM, Krogerus Heikki (EXT-Teleca/Helsinki) wrote: > On Thu, Aug 19, 2010 at 02:40:42PM +0200, ext Anton Vorontsov wrote: >> On Thu, Aug 19, 2010 at 03:09:37PM +0300, Krogerus Heikki (EXT-Teleca/Helsinki) wrote: >>> @@ -909,5 +913,6 @@ void __init rx51_peripherals_init(void) >>> spi_register_board_info(rx51_peripherals_spi_board_info, >>> ARRAY_SIZE(rx51_peripherals_spi_board_info)); >>> omap2_hsmmc_init(mmc); >>> + platform_device_register(&rx51_charger_device); >> >> Maybe >> >> platform_device_register_simple("isp1704_charger", -1, NULL, 0); > > I guess it's enough in this case. Ameya, Roger, any objections? > I'm fine with the current approach. No need to re-spin. -- regards, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/