Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753823Ab0HSWTP (ORCPT ); Thu, 19 Aug 2010 18:19:15 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:63117 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502Ab0HSWTM (ORCPT ); Thu, 19 Aug 2010 18:19:12 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6079"; a="51602616" Message-ID: <4C6DADDE.7030107@codeaurora.org> Date: Thu, 19 Aug 2010 18:19:10 -0400 From: Neil Leeder User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5 MIME-Version: 1.0 To: Dmitry Torokhov CC: Stepan Moskovchenko , "linux-input@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Horace Fu , Mandeep Singh Baines , Trilok Soni Subject: Re: [PATCH v2] input: mouse: add qci touchpad driver References: <1281631760-15589-1-git-send-email-nleeder@codeaurora.org> <20100813024912.GA2661@core.coreip.homeip.net> <4C65BF99.9030601@codeaurora.org> <201008131754.49488.dmitry.torokhov@gmail.com> <4C6AC393.8000109@codeaurora.org> <4C6C52DE.4040700@codeaurora.org> <20100819053311.GE5832@core.coreip.homeip.net> In-Reply-To: <20100819053311.GE5832@core.coreip.homeip.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2322 Lines: 50 Hi Dmitry, On 8/19/2010 1:33 AM, Dmitry Torokhov wrote: > On Wed, Aug 18, 2010 at 05:38:38PM -0400, Neil Leeder wrote: >> Using proto=bare gets around the GETINFO failure, but doesn't help >> with the more important GETID failure. > > Does it help if you change write() to transmit (and read) 1 byte at a time? > Thanks for the suggestions. Nothing I change seems able to get a consistent valid response to GETID. I think this is the first time anyone has written anything other than 0xF4 to the firmware in the EC and it's just not passing through the other PS/2 commands and responses reliably. > One way would be to look for PSMOUSE_CMD_ENABLE/PSMOUSE_CMD_DISABLE > (0xf4/0xf5) in ->write() method to switch between 1 and 3-byte transfers. If I force my way past GETID and set the receive length to 3 based on seeing F4/F5 being written then the touchpad does work. However the serio driver is now a touchpad-specific driver rather than a generic PS/2 one. I have a keyboard on the same device. I'm not sure if it will work with serio, but if so it will probably have its own requirements for the length of data sent on responses, probably not 3. BTW, using 1 as the receive length for commands has its own problems as some commands require more than one byte response (GETID, GETINFO). I can work around it, but it's not particularly clean and getting further away from a generic driver. At this point I'm thinking that the interface is close to being able to work with serio/psmouse, but just not close enough. The unreliability of responding to basic commands as well as the length of data problems indicates some custom driver is going to be needed. That could either be Quanta's original touchpad driver I posted, or a modification of your serio driver. I'd lean towards not having a serio driver which includes workarounds for a specific device, but I'd appreciate hearing your opinion. Thanks. -- Neil -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/