Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416Ab0HTHdG (ORCPT ); Fri, 20 Aug 2010 03:33:06 -0400 Received: from sh.osrg.net ([192.16.179.4]:32800 "EHLO sh.osrg.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750935Ab0HTHdD (ORCPT ); Fri, 20 Aug 2010 03:33:03 -0400 Date: Fri, 20 Aug 2010 16:32:37 +0900 To: nab@linux-iscsi.org Cc: michaelc@cs.wisc.edu, fujita.tomonori@lab.ntt.co.jp, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de, James.Bottomley@suse.de, hare@suse.de Subject: Re: Conversion of LIO-Target to use include/scsi/iscsi_proto.h defs From: FUJITA Tomonori In-Reply-To: <1282257947.30453.296.camel@haakon2.linux-iscsi.org> References: <1282257947.30453.296.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20100820163058P.fujita.tomonori@lab.ntt.co.jp> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (sh.osrg.net [192.16.179.4]); Fri, 20 Aug 2010 16:32:39 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1363 Lines: 32 On Thu, 19 Aug 2010 15:45:47 -0700 "Nicholas A. Bellinger" wrote: > So, assuming that the conversion of all struct iscsi_init_* and struct > iscsi_target* to use include/scsi/iscsi_proto.h defs just involves > checking structure size and renaming the member use in > drivers/target/lio-target, would it be acceptable to do something like: > > /* iSCSI PDU Header */ > struct iscsi_cmd { > uint8_t opcode; > uint8_t flags; > __be16 rsvd2; > uint8_t hlength; > uint8_t dlength[3]; > uint8_t lun[8]; > itt_t itt; /* Initiator Task Tag */ > __be32 data_length; > __be32 cmdsn; > __be32 exp_statsn; > uint8_t cdb[ISCSI_CDB_SIZE]; /* SCSI Command Block */ > /* Additional Data (Command Dependent) */ > #ifdef ISCSI_TARGET_MODE > __be32 header_digest; > #endif > }; It's up to Mike but it looks hacky to me. struct iscsi_pdu is defined in the exact way as the spec does. I don't think that iscsi_proto.h conversion is a must for the mainline inclusion. I prefer to let it alone for now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/