Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752027Ab0HTIcU (ORCPT ); Fri, 20 Aug 2010 04:32:20 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:37585 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324Ab0HTIcT (ORCPT ); Fri, 20 Aug 2010 04:32:19 -0400 Date: Fri, 20 Aug 2010 04:32:13 -0400 From: Christoph Hellwig To: "Aneesh Kumar K.V" Cc: hch@infradead.org, viro@zeniv.linux.org.uk, adilger@sun.com, corbet@lwn.net, neilb@suse.de, npiggin@suse.de, hooanon05@yahoo.co.jp, bfields@fieldses.org, miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, sfrench@us.ibm.com, philippe.deniel@CEA.FR, linux-kernel@vger.kernel.org Subject: Re: [PATCH -V18 05/13] vfs: Support null pathname in readlink Message-ID: <20100820083213.GB10039@infradead.org> References: <1282269097-26166-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1282269097-26166-6-git-send-email-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1282269097-26166-6-git-send-email-aneesh.kumar@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 508 Lines: 10 Changing the interfaces of existing system calls to accept a NULL name which previously wasn't acceptable is not valid. Even for new system calls I think it's a bad idea. utimensat already has the most ugly code of all fs related system calls because of that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/