Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753279Ab0HTIuq (ORCPT ); Fri, 20 Aug 2010 04:50:46 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:49329 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568Ab0HTIuf convert rfc822-to-8bit (ORCPT ); Fri, 20 Aug 2010 04:50:35 -0400 Subject: Re: [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs From: Peter Zijlstra To: Don Zickus Cc: Robert Richter , Cyrill Gorcunov , Lin Ming , Ingo Molnar , "fweisbec@gmail.com" , "linux-kernel@vger.kernel.org" , "Huang, Ying" , Yinghai Lu , Andi Kleen In-Reply-To: <20100819215803.GZ4879@redhat.com> References: <20100804163930.GE5130@lenovo> <20100804184806.GL26154@erda.amd.com> <20100804192634.GG5130@lenovo> <20100806065203.GR26154@erda.amd.com> <20100806142131.GA1874@redhat.com> <20100809194829.GB26154@erda.amd.com> <20100817152225.GQ26154@erda.amd.com> <1282214753.1926.4669.camel@laptop> <20100819141240.GO4879@redhat.com> <1282228033.2605.204.camel@laptop> <20100819215803.GZ4879@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Fri, 20 Aug 2010 10:50:16 +0200 Message-ID: <1282294216.2605.664.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 27 On Thu, 2010-08-19 at 17:58 -0400, Don Zickus wrote: > On Thu, Aug 19, 2010 at 04:27:13PM +0200, Peter Zijlstra wrote: > > x86_pmu.drain_pebs(regs); > > + } > > > > for_each_set_bit(bit, (unsigned long *)&status, X86_PMC_IDX_MAX) { > > struct perf_event *event = cpuc->events[bit]; > > > > + handled++; > > + > > if (!test_bit(bit, cpuc->active_mask)) > > continue; > > Sorry I didn't notice this earlier, but I think you want that handled++ > after the if(..) continue pieces. Otherwise you will always have a number > >1. :-) Only if there's any remaining set bits in the overflow status reg, right? But if we want to be paranoid, we should also check if the event that generated the overflow actually had the INT flag enabled, I guess ;-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/