Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752562Ab0HTJkA (ORCPT ); Fri, 20 Aug 2010 05:40:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:21513 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202Ab0HTJj5 (ORCPT ); Fri, 20 Aug 2010 05:39:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.56,238,1280732400"; d="scan'208";a="830097129" Date: Fri, 20 Aug 2010 17:39:51 +0800 From: Wu Fengguang To: Michael Rubin , Sage Weil Cc: "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "jack@suse.cz" , "riel@redhat.com" , "akpm@linux-foundation.org" , "david@fromorbit.com" , "npiggin@kernel.dk" , "hch@lst.de" , "axboe@kernel.dk" Subject: Re: [PATCH 1/4] mm: exporting account_page_dirty Message-ID: <20100820093951.GA8440@localhost> References: <1282296689-25618-1-git-send-email-mrubin@google.com> <1282296689-25618-2-git-send-email-mrubin@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1282296689-25618-2-git-send-email-mrubin@google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2054 Lines: 57 Sage, This is actually a bug fix for ceph, which missed the task_dirty_inc() call in account_page_dirty(). Reviewed-by: Wu Fengguang On Fri, Aug 20, 2010 at 05:31:26PM +0800, Michael Rubin wrote: > This allows code outside of the mm core to safely manipulate page state > and not worry about the other accounting. Not using these routines means > that some code will lose track of the accounting and we get bugs. This > has happened once already. > > Signed-off-by: Michael Rubin > --- > fs/ceph/addr.c | 8 +------- > mm/page-writeback.c | 1 + > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 5598a0d..420d469 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -105,13 +105,7 @@ static int ceph_set_page_dirty(struct page *page) > spin_lock_irq(&mapping->tree_lock); > if (page->mapping) { /* Race with truncate? */ > WARN_ON_ONCE(!PageUptodate(page)); > - > - if (mapping_cap_account_dirty(mapping)) { > - __inc_zone_page_state(page, NR_FILE_DIRTY); > - __inc_bdi_stat(mapping->backing_dev_info, > - BDI_RECLAIMABLE); > - task_io_account_write(PAGE_CACHE_SIZE); > - } > + account_page_dirtied(page, page->mapping); > radix_tree_tag_set(&mapping->page_tree, > page_index(page), PAGECACHE_TAG_DIRTY); > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 7262aac..9d07a8d 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -1131,6 +1131,7 @@ void account_page_dirtied(struct page *page, struct address_space *mapping) > task_io_account_write(PAGE_CACHE_SIZE); > } > } > +EXPORT_SYMBOL(account_page_dirtied); > > /* > * For address_spaces which do not use buffers. Just tag the page as dirty in > -- > 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/