Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086Ab0HTKIq (ORCPT ); Fri, 20 Aug 2010 06:08:46 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:33774 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254Ab0HTKIn (ORCPT ); Fri, 20 Aug 2010 06:08:43 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Wu Fengguang Subject: Re: [PATCH 2/4] mm: account_page_writeback added Cc: kosaki.motohiro@jp.fujitsu.com, Michael Rubin , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "jack@suse.cz" , "riel@redhat.com" , "akpm@linux-foundation.org" , "david@fromorbit.com" , "npiggin@kernel.dk" , "hch@lst.de" , "axboe@kernel.dk" In-Reply-To: <20100820094525.GB8440@localhost> References: <1282296689-25618-3-git-send-email-mrubin@google.com> <20100820094525.GB8440@localhost> Message-Id: <20100820190803.6009.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Fri, 20 Aug 2010 19:08:40 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 20 > I'm not sure this should be an inline function, just a reminder. > Even with one more inc_zone_page_state() in next patch. > > > +void account_page_writeback(struct page *page) > > +{ > > + inc_zone_page_state(page, NR_WRITEBACK); > > +} > > +EXPORT_SYMBOL(account_page_writeback); Personally, I like inline. but it's no big matter. Reviewed-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/