Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751606Ab0HTVYx (ORCPT ); Fri, 20 Aug 2010 17:24:53 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53375 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038Ab0HTVYv (ORCPT ); Fri, 20 Aug 2010 17:24:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <20100818203143.735033743@clark.site> <1282308887.3170.5439.camel@zakaz.uk.xensource.com> <1282326182.29609.789.camel@localhost.localdomain> <1282336944.2605.1395.camel@laptop> From: Linus Torvalds Date: Fri, 20 Aug 2010 14:24:30 -0700 Message-ID: Subject: Re: [2/3] mm: fix up some user-visible effects of the stack guard page To: Peter Zijlstra Cc: Ian Campbell , linux-kernel@vger.kernel.org, stable@kernel.org, stable-review@kernel.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Greg KH Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 29 On Fri, Aug 20, 2010 at 2:17 PM, Linus Torvalds wrote: > > Appended is that much smaller patch. Note that the "real" patch is actually even smaller than implied by this thing. The diffstat include/linux/mm_types.h | 2 +- kernel/fork.c | 7 +++++-- mm/mmap.c | 37 +++++++++++++++++++++++++++++++++---- mm/nommu.c | 7 +++++-- 4 files changed, 44 insertions(+), 9 deletions(-) implies that it adds a lot more than it removes, but of the 35 new lines it adds, about half of it - 16 lines - is just the vma list verification hack. So it really adds less than 20 lines of code. Hopefully those 20 lines would then buy themselves back with cleanups. Still. A doubly-linked list is totally trivial, and I just bet I have a bug in there somewhere. But looking at your 2007 patch and mine side-by-side, I do think mine is still less scary. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/