Date: Fri, 20 Aug 2010 17:24:50 -0500
From: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Dustin Kirkland <kirkland@canonical.com>,
        ecryptfs-devel@lists.launchpad.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ecryptfs: properly mark init functions
Message-ID: <20100820222450.GA28193@boomer>
References: <4C6AA995.6040008@redhat.com>
 <20100819002836.GA8552@boomer>
 <4C6CEA20.5010802@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C6CEA20.5010802@redhat.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1200
Lines: 33

On Thu Aug 19, 2010 at 10:24:00AM +0200, Jerome Marchand <jmarchan@redhat.com> wrote:
> On 08/19/2010 02:28 AM, Tyler Hicks wrote:
> > On Tue Aug 17, 2010 at 05:24:05PM +0200, Jerome Marchand <jmarchan@redhat.com> wrote:
> >>
> >> Some ecryptfs init functions are not prefixed by __init and thus not
> >> freed after initialization. This patch saved about 1kB in ecryptfs
> >> module.
> >>
> >> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
> >> ---
> > 
> > Thanks Jerome - We could also get away with marking
> > ecryptfs_init_kmem_caches() and do_sysfs_registration() with __init,
> > right?
> > 
> > Tyler
> > 
> 
> I guess we could. But it doesn't really matter, these are static functions which
> are called from only one place, so they're inlined anyway. I don't know what the
> convention is in such case.
> 

Good point - this has been applied to
git://git.kernel.org/pub/scm/linux/kernel/git/ecryptfs/ecryptfs-2.6.git#next

Thanks,
Tyler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/