Date: Sat, 21 Aug 2010 00:25:11 +0200
From: Samuel Ortiz <sameo@linux.intel.com>
To: Rabin Vincent <rabin.vincent@stericsson.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linus WALLEIJ <linus.walleij@stericsson.com>
Subject: Re: [RFC] gpio/stmpe: add bitmask to block requests to unavailable
 GPIOs
Message-ID: <20100820222510.GP3650@sortiz-mobl>
References: <1281971684-16505-1-git-send-email-w.sang@pengutronix.de>
 <20100818100950.GA19706@bnru01.bnr.st.com>
 <20100818103137.GB3528@pengutronix.de>
 <20100819130605.GA25901@bnru01.bnr.st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100819130605.GA25901@bnru01.bnr.st.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1890
Lines: 48

Hi Rabin,

On Thu, Aug 19, 2010 at 06:36:05PM +0530, Rabin Vincent wrote:
> On Wed, Aug 18, 2010 at 12:31:37 +0200, Wolfram Sang wrote:
> > On Wed, Aug 18, 2010 at 03:39:50PM +0530, Rabin VINCENT wrote:
> > > On Mon, Aug 16, 2010 at 17:14:44 +0200, Wolfram Sang wrote:
> > > > GPIOs on these controller are multi-functional. If you decided to use
> > > > some of them e.g. as input channels for the ADC, you surely don't want
> > > > those pins to be reassigned as simple GPIOs (which may be triggered even
> > > > from userspace via 'export'). Same for the touchscreen controller pins.
> > > > Since knowledge about the hardware is needed to decide which GPIOs to
> > > > reserve, let this bitmask be inside platform_data and provide some
> > > > defines to assist potential users.
> > > 
> > > Could this be done without the platform data, say something like the
> > > below?  (Though this does assume that nobody tries to request GPIOs
> > > before the STMPE subdrivers reserve their pins.)
> > > 
> > 
> > While I'd also like to skip the additional platform_data entry, your
> > last comment is in deed a drawback.
> 
> Yes, especially if the subdrivers are dynamically loaded.  Your patch is
> fine with me: 
> 
> Acked-by: Rabin Vincent <rabin.vincent@stericsson.com>
> 
> The only minor comment is that the STMPE_GPIO_NOREQ_811_TOUCH name could
> perhaps be clearer.  STMPE811_GPIO_NOREQ_TOUCHSCREEN, maybe?
I applied Wolfram's patch. If he wants to change this name, he can send an
additional patch later on.

Thanks for the patch and the review.

Cheers,
Samuel.


> Rabin

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/