Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751696Ab0HUAUX (ORCPT ); Fri, 20 Aug 2010 20:20:23 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:50345 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103Ab0HUAUV convert rfc822-to-8bit (ORCPT ); Fri, 20 Aug 2010 20:20:21 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=t2T6lokL3fZj997cAdd96wmWoSJDLFkaUhFzF97jUwg+HR+D4pR2yRQoN4XqTm2dm0 8iQgHl7nek+FXZmxJm6ITQsziOP1M6NsHbMDWDvtD1UVlPhgURq3JWDprGfSGRShi6EW RcPMVBX+3SaiOmDjGTsgGshax2RVAdTTAvisg= MIME-Version: 1.0 In-Reply-To: References: From: Mike Snitzer Date: Fri, 20 Aug 2010 20:20:00 -0400 Message-ID: Subject: Re: [RFC] mlock/stack guard interaction fixup To: Linus Torvalds Cc: Ian Campbell , linux-kernel@vger.kernel.org, stable@kernel.org, stable-review@kernel.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Greg KH , Peter Zijlstra Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 29 On Fri, Aug 20, 2010 at 7:59 PM, Linus Torvalds wrote: > Ian (and others), > ?here's a three-patch series that uses the doubly linked list to do > your mlock() case hopefully correctly. > > NOTE! It's untested. The first patch (which is the slightly scary one) > is tested to some degree, the two other ones I checked that they > compile, but that's it. > > I'm not going to apply them to my main tree unless they get testing > and acks. And as mentioned, I've not done any of the changes that > having a vm_prev pointer can allow in other places. > > Comments? Fixes? Braindamage? In 0002-mm-make-the-mlock-stack-guard-page-checks-stricter.patch you switch __mlock_vma_pages_range from 'start += PAGE_SIZE' to 'addr += PAGE_SIZE'. So would that be a bugfix for commit d7824370? Seems likely given start isn't used after that point. Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/